[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-10-06 Thread via cfe-commits
Naville wrote: I'll take a look at into improving llvm-config https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-10-05 Thread Mike Hommey via cfe-commits
glandium wrote: > Which used to be MT and with this change is now MD. (because our script was still using LLVM_USE_CRT_RELEASE) https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-10-05 Thread Mike Hommey via cfe-commits
glandium wrote: This unveiled an interesting problem in our builds: `llvm-config --cxxflags` doesn't include the `/MT`/`/MD` flag, so when building something that links with one of the .lib from LLVM, you can end up with a failure because you're not building with the same flag as LLVM was buil

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-21 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-21 Thread via cfe-commits
Naville wrote: Push the buttom for me please :D https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-21 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > LGTM, thanks. (But let's wait with landing it until e.g. tomorrow, in case > someone else has comments on it.) I think this should be fine to land now. Do you have commit access, or do you want me to push the button? https://github.com/llvm/llvm-project/pull/66850 __

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-20 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. LGTM, thanks. (But let's wait with landing it until e.g. tomorrow, in case someone else has comments on it.) https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commi

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-20 Thread via cfe-commits
Naville wrote: Updated the commit message @mstorsjo https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-20 Thread via cfe-commits
https://github.com/Naville edited https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-20 Thread via cfe-commits
https://github.com/Naville edited https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits