[clang] [CUDA][HIP] Fix deduction guide (PR #69366)

2023-11-15 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > > @ldionne - Can you take a look if that would have unintended consequences > > for libc++? > > Honestly, I don't know. I don't know CUDA nearly well enough to understand > all the implications here. All I know is that this seems to be a pretty > significant "fork" of C++ in

[clang] [CUDA][HIP] Fix deduction guide (PR #69366)

2023-11-01 Thread Tom Honermann via cfe-commits
tahonermann wrote: For what it is worth, the described behavior sounds right to me from a design perspective. The fact that it matches `nvcc` behavior is a very good hint that it is the desired behavior as well. I haven't reviewed the code changes, but as long as they implement what is describ

[clang] [CUDA][HIP] Fix deduction guide (PR #69366)

2023-10-30 Thread Artem Belevich via cfe-commits
Artem-B wrote: @ldionne - Can you take a look if that would have unintended consequences for libc++? https://github.com/llvm/llvm-project/pull/69366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [CUDA][HIP] Fix deduction guide (PR #69366)

2023-10-17 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: nvcc behavior can be seen here https://godbolt.org/z/sY1vdYWKe https://godbolt.org/z/vTer7xa3j https://github.com/llvm/llvm-project/pull/69366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [CUDA][HIP] Fix deduction guide (PR #69366)

2023-10-17 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/69366 >From b28384d33f858a6d4139da931b436cbf1a0a426a Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Sat, 14 Oct 2023 17:28:13 -0400 Subject: [PATCH] [CUDA][HIP] Fix deduction guide Currently clang assumes imp

[clang] [CUDA][HIP] Fix deduction guide (PR #69366)

2023-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes Currently clang assumes implicit deduction guide to be host device. This generates two identical implicit deduction guides when a class have a device and a host constructor which have the same input para

[clang] [CUDA][HIP] Fix deduction guide (PR #69366)

2023-10-17 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/69366 Currently clang assumes implicit deduction guide to be host device. This generates two identical implicit deduction guides when a class have a device and a host constructor which have the same input parameter a