[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-15 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/122859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Can we get a new test showing CUDA? CUDA uses the new driver by default so > cuid stuff will be missing there. Added. https://github.com/llvm/llvm-project/pull/122859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/122859 >From 38939c7ecd5b29d92cffcb4fa3911159bd37d0e5 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Mon, 13 Jan 2025 14:12:52 -0500 Subject: [PATCH] [CUDA][HIP] Support CUID in new driver CUID is needed by C

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > > Yeah, that's fine, but we should just default to the inode method if the > argument isn't present I think. That way it works without needing this extra > argument passed to both the compile phases. That would break rccl. We should use CUID's that work in general, including

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > That would break rccl. We should use CUID's that work in general, including > apps that compile the same file with different options. Shouldn't be broken if the driver handles the CUID, I just mean that it would work in `cc1` if not passed. https://github.com/llvm/llvm-proj

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: Can we get a new test showing CUDA? CUDA uses the new driver by default so cuid stuff will be missing there. https://github.com/llvm/llvm-project/pull/122859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > > > I thought the new driver just got some entropy from the current source > > > > file's `inode` entry? I'm not opposed, since I guess it would make > > > > sense to give the user a way to override it. > > > > > > > > > Sorry I did not quite get your question. Do you sugge

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > > > I thought the new driver just got some entropy from the current source > > > file's `inode` entry? I'm not opposed, since I guess it would make sense > > > to give the user a way to override it. > > > > > > Sorry I did not quite get your question. Do you suggest that we

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I thought the new driver just got some entropy from the current source > > file's `inode` entry? I'm not opposed, since I guess it would make sense to > > give the user a way to override it. > > Sorry I did not quite get your question. Do you suggest that we need some > opt

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > I thought the new driver just got some entropy from the current source file's > `inode` entry? I'm not opposed, since I guess it would make sense to give the > user a way to override it. Sorry I did not quite get your question. Do you suggest that we need some option to over

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: I thought the new driver just got some entropy from the current source file's `inode` entry? I'm not opposed, since I guess it would make sense to give the user a way to override it. https://github.com/llvm/llvm-project/pull/122859

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Yaxun (Sam) Liu (yxsamliu) Changes CUID is needed by CUDA/HIP for supporting accessing static device variables in host function. Currently CUID is only supported by the old driver for CUDA/HIP. The new driver does not support it,

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-13 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/122859 CUID is needed by CUDA/HIP for supporting accessing static device variables in host function. Currently CUID is only supported by the old driver for CUDA/HIP. The new driver does not support it, which causes