[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-12-01 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/73140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-30 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/73140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-30 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: ping https://github.com/llvm/llvm-project/pull/73140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-22 Thread via cfe-commits
alexfh wrote: Thank you! https://github.com/llvm/llvm-project/pull/73140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-22 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Could you first land the two reverts > ([511cecf](https://github.com/llvm/llvm-project/commit/511cecff7f76958ebfe713189bc106615763b64a) > and > [e9a8e90](https://github.com/llvm/llvm-project/commit/e9a8e906d4c14eb4b317a7420b9bba3dc7321ba2)) > and then have the third commit p

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-22 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/73140 >From 2dc8bda89483ee655e7a76deac19b8ea9e463c7b Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Wed, 22 Nov 2023 10:02:59 -0500 Subject: [PATCH] [CUDA][HIP] allow trivial ctor/dtor in device var init Trea

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-22 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Could you first land the two reverts > ([511cecf](https://github.com/llvm/llvm-project/commit/511cecff7f76958ebfe713189bc106615763b64a) > and > [e9a8e90](https://github.com/llvm/llvm-project/commit/e9a8e906d4c14eb4b317a7420b9bba3dc7321ba2)) > and then have the third commit p

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-22 Thread via cfe-commits
alexfh wrote: Could you first land the two reverts (511cecff7f76958ebfe713189bc106615763b64a and e9a8e906d4c14eb4b317a7420b9bba3dc7321ba2) and then have the third commit properly reverted? @Artem-B may be unavailable for a few more days, but we'd like a fix/revert to land very soon. https://g

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes Treat ctor/dtor in device var init as host device function so that they can be used to initialize file-scope device variables to match nvcc behavior. If they are non-trivial they will be diagnosed. We can

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

2023-11-22 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/73140 Treat ctor/dtor in device var init as host device function so that they can be used to initialize file-scope device variables to match nvcc behavior. If they are non-trivial they will be diagnosed. We cannot add