https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86682
>From 125b91778874e9f61e178ea4dd2efaf592ea84bb Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 26 Mar 2024 11:27:28 -0400
Subject: [PATCH] [Clang][AST][NFC] Move template argument dependence
com
sdkrystian wrote:
Thanks! I'll add a comment on the other PR saying the commit was reviewed here
& then I'll merge
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
erichkeane wrote:
Ah, i see... yeah, i think there is value to submitting them separately, feel
free to do so.
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
sdkrystian wrote:
@erichkeane Just merging this PR will result in the commits being squashed into
a single commit... is that alright?
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
erichkeane wrote:
> @erichkeane Requested changes applied... should I wait for other reviews on
> the other PR (#86678), or do you think I should go ahead and merge #86678 and
> then this one?
#86678 is entirely 'contained' in this review, right? Seems like it is
'reviewed', so you can proba
sdkrystian wrote:
@erichkeane Requested changes applied... should I wait for other reviews on the
other PR (#86678), or do you think I should go ahead and merge #86678 and then
this one?
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits
@@ -583,11 +583,14 @@ class alignas(void *) Stmt {
unsigned IsArrow : 1;
/// True if this member expression used a nested-name-specifier to
-/// refer to the member, e.g., "x->Base::f", or found its member via
-/// a using declaration. When true, a MemberExprN
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/86682
>From d257fa46da4f84dfcedfa8d25267f3326996d72e Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 26 Mar 2024 10:04:44 -0400
Subject: [PATCH 1/2] [Clang][AST][NFC] MemberExpr stores
NestedNameSpeci
@@ -1735,48 +1757,21 @@ MemberExpr *MemberExpr::Create(
ValueDecl *MemberDecl, DeclAccessPair FoundDecl,
DeclarationNameInfo NameInfo, const TemplateArgumentListInfo *TemplateArgs,
QualType T, ExprValueKind VK, ExprObjectKind OK, NonOdrUseReason NOUR) {
- bool HasQ
@@ -1735,48 +1757,21 @@ MemberExpr *MemberExpr::Create(
ValueDecl *MemberDecl, DeclAccessPair FoundDecl,
DeclarationNameInfo NameInfo, const TemplateArgumentListInfo *TemplateArgs,
QualType T, ExprValueKind VK, ExprObjectKind OK, NonOdrUseReason NOUR) {
- bool HasQ
https://github.com/erichkeane approved this pull request.
2 nits, else LGTM.
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -583,11 +583,14 @@ class alignas(void *) Stmt {
unsigned IsArrow : 1;
/// True if this member expression used a nested-name-specifier to
-/// refer to the member, e.g., "x->Base::f", or found its member via
-/// a using declaration. When true, a MemberExprN
sdkrystian wrote:
Ping @erichkeane
https://github.com/llvm/llvm-project/pull/86682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
(This patch depends on #86678)
Pretty straightforward change, addresses the FIXME's in
`computeDependence(MemberExpr*)` and `MemberExpr::Create` by moving the
template argument dependence computat
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/86682
(This patch depends on #86678)
Pretty straightforward change, addresses the FIXME's in
`computeDependence(MemberExpr*)` and `MemberExpr::Create` by moving the
template argument dependence computations to `co
17 matches
Mail list logo