https://github.com/jeremyd2019 closed
https://github.com/llvm/llvm-project/pull/143166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kikairoya wrote:
I have a test already: https://github.com/llvm/llvm-project/pull/143115
https://github.com/llvm/llvm-project/pull/143166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
jeremyd2019 wrote:
None of those really cry out to me as a place to add a cygwin test... but
adding a new test in CodeGen that validates that the va_list works the same on
windows and cygwin based on the existing tests wouldn't be too hard.
https://github.com/llvm/llvm-project/pull/143166
mstorsjo wrote:
> I'm not seeing an obvious place for a target-specific va_list test, can you
> suggest where this would go?
No idea offhand; I tried breaking the existing `getBuiltinVaListKind` for
`WindowsX86_64TargetInfo` and running `check-clang`, which caused failures in
the following te
jeremyd2019 wrote:
I'm not seeing an obvious place for a target-specific va_list test, can you
suggest where this would go?
https://github.com/llvm/llvm-project/pull/143166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
jeremyd2019 wrote:
I don't know - it's easy enough to do *in vivo*
```c
#include
#include
void test(const char * fmt, ...)
{
va_list args;
va_start(args, fmt);
vprintf(fmt, args);
va_end(args);
}
int main(void)
{
test("asdf %d %s\n", 1, 1==1 ? "TEST" :
mstorsjo wrote:
The change looks good, but can we have a test for it in some form?
https://github.com/llvm/llvm-project/pull/143166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jeremyd2019 wrote:
@mstorsjo
https://github.com/llvm/llvm-project/pull/143166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (jeremyd2019)
Changes
This was in older patches for Cygwin support, but was somehow lost in the
latest rounds.
---
Full diff: https://github.com/llvm/llvm-project/pull/143166.diff
1 Files Affected:
- (modified) clang/lib/Basic/Tar
https://github.com/jeremyd2019 created
https://github.com/llvm/llvm-project/pull/143166
This was in older patches for Cygwin support, but was somehow lost in the
latest rounds.
>From d3b165f3db087d9255c5c9e40b7636d79fc57c6e Mon Sep 17 00:00:00 2001
From: Jeremy Drake
Date: Fri, 6 Jun 2025 09:
10 matches
Mail list logo
