[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/khei4 closed https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From 12e29c46366e93c98c96e7561258bc83f66755c1 Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH 1/2] use create instead of protected Constructor --- clang/docs/LibTooling.

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

@@ -63,15 +63,22 @@ and automatic location of the compilation database using source files paths. #include "llvm/Support/CommandLine.h" using namespace clang::tooling; + using namespace llvm; // Apply a custom category to all command-line options so that they are the

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/Sirraide approved this pull request. LGTM except for one minor issue. https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

Xulei-NL wrote: Nice that the author has created this PR for fixing the inconsistent LibTooling document. This PR is very important to clang LibTooling beginners. Could the reviewers please approve it soon? :smiley: https://github.com/llvm/llvm-project/pull/70427 __

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/khei4 ready_for_review https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From 12e29c46366e93c98c96e7561258bc83f66755c1 Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH] use create instead of protected Constructor --- clang/docs/LibTooling.rst

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/khei4 edited https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From 166f580fda7a7cf4b87b167be03777d28638feff Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH 1/2] use create instead of protected Constructor --- clang/docs/LibTooling.

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

https://github.com/khei4 edited https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits