aeubanks wrote:
We can still pass `-mllvm` for LTO builds.
If we have a more lightweight version, then I wonder if we just fold that under
the previous verification flag.
Yeah I'd hold off on this until we have a more compelling reason to add it.
https://github.com/llvm/llvm-project/pull/7028
mizvekov wrote:
I don't disagree that if we stop at this step, then the flag doesn't buy much.
But it would be worthwhile if we ever implemented LTO integration or
implemented a lightweight machine verification which runs the pass 1 or 2
times, which would work similarly to the IR verification
aeubanks wrote:
agreed that `-mllvm -verify-machineinstrs` is good enough
https://github.com/llvm/llvm-project/pull/70282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikic wrote:
I'm not convinced that adding this flag makes sense, given that you can already
use `-mllvm -verify-machineinstrs`. This is a developer option, and I don't
think it should be exposed by the clang driver (and if you expose it in cc1
only, then `-Xclang -fverify-machine-code` is rea
@@ -525,6 +525,11 @@
// CHECK-VERIFY-INTERMEDIATE-CODE-NOT: "-disable-llvm-verifier"
// CHECK-NO-VERIFY-INTERMEDIATE-CODE: "-disable-llvm-verifier"
+// RUN: %clang -### -S -fverify-machine-code %s 2>&1 | FileCheck
-check-prefix=CHECK-VERIFY-MACHINE-CODE %s
+// RUN: %clang -##
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/70282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/70282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"],
"fverify-intermediate-code">,
def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">,
Group, Visibility<[ClangOption, CLOption, DXCOption]>,
HelpText<"Disable verification of LLVM IR
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/70282
>From b2006f46ebfd1da17014cf6c577da4700c355d00 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Wed, 4 Oct 2023 12:09:15 +0200
Subject: [PATCH] [Clang][Driver] Add new flags to control machine instruction
v
@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"],
"fverify-intermediate-code">,
def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">,
Group, Visibility<[ClangOption, CLOption, DXCOption]>,
HelpText<"Disable verification of LLVM IR
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/70282
>From 9f3711c112159c57becae105561bc988a0caaeb5 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Thu, 26 Oct 2023 06:07:57 +0200
Subject: [PATCH 1/2] [clang][driver] remove accidentally added NoXarchOption
f
@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"],
"fverify-intermediate-code">,
def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">,
Group, Visibility<[ClangOption, CLOption, DXCOption]>,
HelpText<"Disable verification of LLVM IR
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
Present shortcomings are that this only works for non-LTO builds, and that this
new pass doesn't work quite the same as the IR verification flag, as it runs
between every machine pass and is thus much mo
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/70282
Present shortcomings are that this only works for non-LTO builds, and that this
new pass doesn't work quite the same as the IR verification flag, as it runs
between every machine pass and is thus much more expe
14 matches
Mail list logo
