shiltian wrote:
I got it that you are trying to make it generic. That's why I didn’t roll back
to using builtin bitcode as we did before. However there is one limitation that
we can't really work around, which is the fact that we don't support ABI
linking. This is not a new topic at all and wh
jhuber6 wrote:
> I don't think OpenMP is more special than HIP here. Anything exposed to the
> host should not be internalized. In addition, OpenMP actually also heavily
> uses internalization as well in OpenMPOpt. It is likely that this change
> exposes something bad in the downstream.
>
> T
shiltian wrote:
> also seeing
>
> "PluginInterface" error: Failure to look up global address: Error in
> hsa_executable_get_symbol_by_name(grid_points):
> HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name.
>
> omptarget error: Failed to load symbol grid_points
>
>
shiltian wrote:
I don't think OpenMP is more special than HIP here. Anything exposed to the
host should not be internalized. In addition, OpenMP actually also heavily uses
internalization as well in OpenMPOpt. It is likely that this change exposes
something bad in the downstream.
The motivati
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(Args.MakeArgString(
"--device-linker=" + TC->getTripleString() + "=" + Arg));
+ // Enable internalization for AMDGPU.
+ if (TC->getTrip
jhuber6 wrote:
> also seeing "PluginInterface" error: Failure to look up global address: Error
> in hsa_executable_get_symbol_by_name(grid_points):
> HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name.
> omptarget error: Failed to load symbol grid_points
Yeah, this i
ronlieb wrote:
also seeing
"PluginInterface" error: Failure to look up global address: Error in
hsa_executable_get_symbol_by_name(grid_points):
HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name.
omptarget error: Failed to load symbol grid_points
https://github.com/l
ronlieb wrote:
downstream testing is seeing quite a few tests failing with:
OFFLOAD ERROR: Memory access fault by GPU 2 (agent 0x145ba00) at virtual
address (nil). Reasons: Unknown (0)
https://github.com/llvm/llvm-project/pull/138365
___
cfe-commits
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(Args.MakeArgString(
"--device-linker=" + TC->getTripleString() + "=" + Arg));
+ // Enable internalization for AMDGPU.
+ if (TC->getTrip
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(Args.MakeArgString(
"--device-linker=" + TC->getTripleString() + "=" + Arg));
+ // Enable internalization for AMDGPU.
+ if (TC->getTrip
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(Args.MakeArgString(
"--device-linker=" + TC->getTripleString() + "=" + Arg));
+ // Enable internalization for AMDGPU.
+ if (TC->getTrip
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(Args.MakeArgString(
"--device-linker=" + TC->getTripleString() + "=" + Arg));
+ // Enable internalization for AMDGPU.
+ if (TC->getTrip
https://github.com/shiltian closed
https://github.com/llvm/llvm-project/pull/138365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/138365
>From c9a8e6e2d67d8e7d029e58402c17d8c9419cd028 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Fri, 2 May 2025 19:41:11 -0400
Subject: [PATCH] [Clang][Driver] Enable internalization by default for AMDGPU
---
https://github.com/jdoerfert approved this pull request.
https://github.com/llvm/llvm-project/pull/138365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Shilei Tian (shiltian)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/138365.diff
2 Files Affected:
- (modified) clang/lib/Driver/ToolChains/Clang.cpp (+6)
- (modified) clang/test/Driver/openmp-offload-gpu.c (
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Shilei Tian (shiltian)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/138365.diff
2 Files Affected:
- (modified) clang/lib/Driver/ToolChains/Clang.cpp (+6)
- (modified) clang/test/Driver/openmp-offload-gpu.c (+7)
shiltian wrote:
* **#138365** https://app.graphite.dev/github/pr/llvm/llvm-project/138365?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/138
https://github.com/shiltian created
https://github.com/llvm/llvm-project/pull/138365
None
>From acc89cf6a85a8fb758b528a4e2ae587fccd61ce5 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Fri, 2 May 2025 19:41:11 -0400
Subject: [PATCH] [Clang][Driver] Enable internalization by default for AMDGPU
19 matches
Mail list logo
