[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/67366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-26 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/67366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67366 >From 19b73b3461f2dde1d7df6ef247f46b221cc652d4 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 25 Sep 2023 15:41:54 -0500 Subject: [PATCH] [Clang][HIP] Remove 'clangPostLink' from SDL handling Summary: Th

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 62f5636838ac80ebe8db9c31cdf9c5566db8f0c9 8076d6182a44daf6fee0165922aa30d0fb1786d5 --

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Long term I'd like to move HIP to the new driver so we can delete all of this SDL handling code. That would require someone guiding me through how to test the toolchain on Windows so I can make the linker wrapper work with the Windows linker. https://github.com/llvm/llvm-projec

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes Summary: This feature is not needed anymore and is replaced by different implementations. The code guarded by this flag also causes us to emit an invalid argument to `-mlink-builtin-bitcode` that will cause errors if ever actually exe

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67366 Summary: This feature is not needed anymore and is replaced by different implementations. The code guarded by this flag also causes us to emit an invalid argument to `-mlink-builtin-bitcode` that will cause errors