https://github.com/SixWeining approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/69313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7df92fbe74e3c1b41c06f5fc784473f7f22aeed7
0bd36f11c5d1da2447b1c123445a1472372a096b --
https://github.com/SixWeining requested changes to this pull request.
- For the commits `[LoongArch][CodeGen][clang] Add builtin functions test cases
for LASX` and `[LoongArch][CodeGen][clang] Add builtin functions test cases for
LSX`, `Change-Id`s can be removed.
- Please fix the test
SixWeining wrote:
> Given you've already split your changes into several smaller commits, it's
> probably better to file them as separate PRs, so each one is smaller than the
> current 3+-line diff, and become more reviewable that way.
I'm not sure seperate PRs are appropriate since some
xen0n wrote:
According to [the *LLVM GitHub user
guide*](https://llvm.org/docs/GitHub.html#creating-pull-requests):
> If you have multiple changes you want to introduce, it’s recommended to
> create separate pull requests for each change.
Given you've already split your changes into several
