[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/17927 Here is the relevant piece of

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-18 Thread Mészáros Gergely via cfe-commits
https://github.com/Maetveis closed https://github.com/llvm/llvm-project/pull/131447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-18 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/131447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-18 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > I can experiment with --filter-out, but I'd prefer to do that as a followup. If you want, you can run the IR through "opt -passes=mem2reg" or something... we just don't want to run the full optimization pipeline because that leads to a bunch of spurious changes to clang

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-18 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: > > This is a lot of tests... do we really need every combination of > > type/operator/flag? I guess it makes sure we don't have gaps, but thousands > > of lines of tests seems excessive. > > It does seem like a lot of testing, but I'd rather we be excessive than take > our hi

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > This is a lot of tests... do we really need every combination of > type/operator/flag? I guess it makes sure we don't have gaps, but thousands > of lines of tests seems excessive. It does seem like a lot of testing, but I'd rather we be excessive than take our historical

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-17 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: This is a lot of tests... do we really need every combination of type/operator/flag? I guess it makes sure we don't have gaps, but thousands of lines of tests seems excessive. https://github.com/llvm/llvm-project/pull/131447 ___

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-15 Thread Mészáros Gergely via cfe-commits
https://github.com/Maetveis ready_for_review https://github.com/llvm/llvm-project/pull/131447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mészáros Gergely (Maetveis) Changes - Add tests for complex divdent and real divisor - Add tests for complex * real multiplication - Add tests for multiply/divide and assign (`/=`,`*=`) operators --- Patch is 510.90 KiB, truncated to 20.0

[clang] [Clang][NFC] Extend cmplx range tests for #131129 (PR #131447)

2025-03-15 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: * **#131447** https://app.graphite.dev/github/pr/llvm/llvm-project/131447?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/131