[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-07 Thread Shilei Tian via cfe-commits
shiltian wrote: I have merged it given our front end expert @alexey-bataev has approved it. https://github.com/llvm/llvm-project/pull/71480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-07 Thread Shilei Tian via cfe-commits
https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/71480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-07 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. Looks like correct fix to me. https://github.com/llvm/llvm-project/pull/71480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
sun-jacobi wrote: Moreover, in the original implementation, the `checkStatement` return false if and only if there is no error in the statement. The question is whether `checkStatement` should consider a statement, which contains semantic errors not related to the atomic directive, as a `NoErr

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
sun-jacobi wrote: > This doesn't look like the right place to fix this issue to me. > @alexey-bataev might have better suggestion. The crash occurs at https://github.com/llvm/llvm-project/blob/d34a10a47d25103725174c62ed5e84e8ca380249/clang/lib/Sema/SemaOpenMP.cpp#L13011 The reason why I fix

[clang] [Clang][OpenMP] fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/71480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP]: fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread Shilei Tian via cfe-commits
shiltian wrote: This doesn't look like the right place to fix this issue to me. @alexey-bataev might have better suggestion. https://github.com/llvm/llvm-project/pull/71480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang][OpenMP]: fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
https://github.com/sun-jacobi updated https://github.com/llvm/llvm-project/pull/71480 >From 265c0586330a678ef61a64c9610cf0ee7c51367f Mon Sep 17 00:00:00 2001 From: sun-jacobi Date: Tue, 7 Nov 2023 12:06:28 +0900 Subject: [PATCH 1/2] [Clang][OpenMP]: fixed crash due to invalid binary expression

[clang] [Clang][OpenMP]: fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chia (sun-jacobi) Changes This PR fixes https://github.com/llvm/llvm-project/issues/69069 . --- Full diff: https://github.com/llvm/llvm-project/pull/71480.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaOpenMP.cpp (+7) `

[clang] [Clang][OpenMP]: fixed crash due to invalid binary expression in checking atomic semantics (PR #71480)

2023-11-06 Thread via cfe-commits
https://github.com/sun-jacobi created https://github.com/llvm/llvm-project/pull/71480 This PR fixes https://github.com/llvm/llvm-project/issues/69069 . >From 265c0586330a678ef61a64c9610cf0ee7c51367f Mon Sep 17 00:00:00 2001 From: sun-jacobi Date: Tue, 7 Nov 2023 12:06:28 +0900 Subject: [PATC