https://github.com/agozillon closed
https://github.com/llvm/llvm-project/pull/67844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shraiysh wrote:
> I'll see what I can do about adding an OpenMPIRBuilderTest.cpp to the patch.
I think it’s okay if it’s tested by clang tests (as Johannes mentioned). In
case you decide to add tests for this, there is already an
OpenMPIRBuilderTest.cpp in `llvm/unittests/Frontend/OpenMPIRBuil
agozillon wrote:
Thank you all very much, I'll land this on Tuesday afternoon/evening provided
no one has anything else to add in the time between. And I'll see what I can do
about adding an OpenMPIRBuilderTest.cpp to the patch.
https://github.com/llvm/llvm-project/pull/67844
https://github.com/jdoerfert approved this pull request.
LG, tested via the clang tests.
https://github.com/llvm/llvm-project/pull/67844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shraiysh wrote:
LGTM. Is it possible to add some tests for this? I think we might be able to
add some in OpenMPIRBuilderTest.cpp.
https://github.com/llvm/llvm-project/pull/67844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/raghavendhra approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
This patch seeks to move the following functions to the OMPIRBuilder:
- getFlagMemberOffset
- getMemberOfFlag
- setCorrectMemberOfFlag
These small helper functions help set the end bits of the
OpenMPOffloadMappingFlags flag that corresp
https://github.com/agozillon created
https://github.com/llvm/llvm-project/pull/67844
This patch seeks to move the following functions to the OMPIRBuilder:
- getFlagMemberOffset
- getMemberOfFlag
- setCorrectMemberOfFlag
These small helper functions help set the end bits of the
OpenMPOffload
