[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -emit-llvm -fopenmp -disable-llvm-passes %s -verify=expected + +// expected-error@+2 {{cannot compile this OpenMP dispatch directive yet}} +void a(){ +#pragma omp dispatch +a(); +} rkchang wrote: Added, thanks https:/

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

https://github.com/rkchang updated https://github.com/llvm/llvm-project/pull/70233 >From 72c056b825963d0de1dcf3fe3a6de922098d0ad9 Mon Sep 17 00:00:00 2001 From: Raymond Chang Date: Thu, 12 Oct 2023 01:51:03 -0400 Subject: [PATCH 1/3] Emit unsupported directive error --- clang/lib/CodeGen/CGSt

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -emit-llvm -fopenmp -disable-llvm-passes %s -verify=expected + +// expected-error@+2 {{cannot compile this OpenMP dispatch directive yet}} +void a(){ +#pragma omp dispatch +a(); +} shiltian wrote: Leave an empty line a

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

https://github.com/shiltian approved this pull request. LG with a nit https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

rkchang wrote: Added a test case. Thanks for the pointer! Here's the result: ``` ~/dev/fork-llvm-project omp_dispatch_unimpl ❯ llvm-lit -vv clang/test/OpenMP/dispatch_unsupported.c llvm-lit: /home/rkchang/dev/fork-llvm-project/llvm/utils/lit/lit/llvm/config.py:488: note: using clang: /home/rkc

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

https://github.com/rkchang updated https://github.com/llvm/llvm-project/pull/70233 >From 72c056b825963d0de1dcf3fe3a6de922098d0ad9 Mon Sep 17 00:00:00 2001 From: Raymond Chang Date: Thu, 12 Oct 2023 01:51:03 -0400 Subject: [PATCH 1/2] Emit unsupported directive error --- clang/lib/CodeGen/CGSt

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

shiltian wrote: Can you add a small test to check the error message is correctly emitted? You can refer to those diagnosis tests under `clang/test/OpenMP`. https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits