https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/82417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/82417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Also added a couple more tests since the diagnostics currently depend on
whether instantiation occurs.
https://github.com/llvm/llvm-project/pull/82417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/82417
>From 06fe8f513866684b70b044524eba9ece9d2701c0 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 20 Feb 2024 14:03:50 -0500
Subject: [PATCH] [Clang][Sema] Defer instantiation of exception
sdkrystian wrote:
@erichkeane Added release note, relevant standardese quote, and some exposition.
https://github.com/llvm/llvm-project/pull/82417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/82417
>From e669903ec50ef0fb1297f150e3a4eb6837db1b53 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 20 Feb 2024 14:03:50 -0500
Subject: [PATCH] [Clang][Sema] Defer instantiation of exception
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/82417
>From 3966e98d9eb6c04faf8a7fd0c4de804964437595 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 20 Feb 2024 14:03:50 -0500
Subject: [PATCH] [Clang][Sema] Defer instantiation of exception
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/82417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
1 nit, else LGTM. We should probably have a release note as well.
https://github.com/llvm/llvm-project/pull/82417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -9706,9 +9706,17 @@ bool Sema::CheckFunctionTemplateSpecialization(
if (Result == Candidates.end())
return true;
- // Ignore access information; it doesn't figure into redeclaration checking.
FunctionDecl *Specialization = cast(*Result);
+ auto
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/82417
>From 16b6ce3b1895c15ce896c5e8dcbe29ee1274d38b Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 20 Feb 2024 14:03:50 -0500
Subject: [PATCH] [Clang][Sema] Defer instantiation of exception
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
Consider the following:
```cpp
struct A {
static constexpr bool x = true;
};
templatetypename T, typename U
void f(T, U) noexcept(T::y); // #1, error: no member named 'y' in 'A'
templatetypename
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/82417
Consider the following:
```cpp
struct A {
static constexpr bool x = true;
};
template
void f(T, U) noexcept(T::y); // #1, error: no member named 'y' in 'A'
template
void f(T, U*) noexcept(T::x); // #2
13 matches
Mail list logo