[clang] [Clang][Sema] Fix NULL dereferences for invalid references (PR #77703)

2024-03-01 Thread Erich Keane via cfe-commits
erichkeane wrote: I spent a while debugging this, and this is far from the correct solution. However, in my debugging I was able to identify the correct solution, so I'll prepare a patch to fix this, closing. https://github.com/llvm/llvm-project/pull/77703

[clang] [Clang][Sema] Fix NULL dereferences for invalid references (PR #77703)

2024-03-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/77703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix NULL dereferences for invalid references (PR #77703)

2024-02-29 Thread Erich Keane via cfe-commits
erichkeane wrote: Yeah, this doesn't seem right to me. Info is a reference, and thus cannot be null by language rule. A sufficiently smart compiler will remove your check. If we're SOMEHOW (though I don't see how?) setting it to nullptr, we need to fix that as that is not intended, nor

[clang] [Clang][Sema] Fix NULL dereferences for invalid references (PR #77703)

2024-02-28 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik requested changes to this pull request. I don't believe this is the right approach. I can only replicate one of the issues: https://godbolt.org/z/7dee3a3cY I spent some time looking at it and it is quite gnarly but we need to understand better what is going on.

[clang] [Clang][Sema] Fix NULL dereferences for invalid references (PR #77703)

2024-01-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (DavidKorczynski) Changes OSS-Fuzz has reported for a bit of time (since early 2020) a couple of NULL dereferences due to the Info reference becoming a reference to a NULL pointer. Am not entirely sure if this is the desired fix

[clang] [Clang][Sema] Fix NULL dereferences for invalid references (PR #77703)

2024-01-10 Thread via cfe-commits
https://github.com/DavidKorczynski created https://github.com/llvm/llvm-project/pull/77703 OSS-Fuzz has reported for a bit of time (since early 2020) a couple of NULL dereferences due to the Info reference becoming a reference to a NULL pointer. Am not entirely sure if this is the desired fix