[clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2024-07-17 Thread via cfe-commits
cor3ntin wrote: @ecnelises are you still working on that? https://github.com/llvm/llvm-project/pull/71696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang-tools-extra] [compiler-rt] [llvm] [flang] [clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2024-01-12 Thread Aaron Ballman via cfe-commits
@@ -799,6 +799,11 @@ Bug Fixes to C++ Support completes (except deduction guides). Fixes: (`#59827 `_) +- Clang now reports error when overriden method's non-class return type drops + qualifiers, or qualifiers of class re

[compiler-rt] [libcxx] [clang-tools-extra] [llvm] [flang] [clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2023-11-14 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon commented: LGTM, but someone else must approve. I added more folks for visibility. https://github.com/llvm/llvm-project/pull/71696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2023-11-09 Thread Qiu Chaofan via cfe-commits
@@ -289,3 +289,29 @@ namespace PR8168 { static void foo() {} // expected-error{{'static' member function 'foo' overrides a virtual function}} }; } + +namespace T13 { + class A { + public: +virtual const int* foo(); // expected-note{{overridden virtual function is

[clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2023-11-08 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/71696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2023-11-08 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon commented: Perhaps also needs a release note. https://github.com/llvm/llvm-project/pull/71696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2023-11-08 Thread Mariya Podchishchaeva via cfe-commits
@@ -289,3 +289,29 @@ namespace PR8168 { static void foo() {} // expected-error{{'static' member function 'foo' overrides a virtual function}} }; } + +namespace T13 { + class A { + public: +virtual const int* foo(); // expected-note{{overridden virtual function is

[clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qiu Chaofan (ecnelises) Changes If return type of overriden method is pointer or reference to non-class type, qualifiers cannot be dropped. This also fixes check when qualifier of overriden method's class return type is not subset of supe

[clang] [Clang][Sema] Fix qualifier restriction of overriden methods (PR #71696)

2023-11-08 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises created https://github.com/llvm/llvm-project/pull/71696 If return type of overriden method is pointer or reference to non-class type, qualifiers cannot be dropped. This also fixes check when qualifier of overriden method's class return type is not subset of super m