[clang] [Clang][TableGen] Add Features to TargetBuiltin (PR #80279)

https://github.com/wangpc-pp closed https://github.com/llvm/llvm-project/pull/80279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Add Features to TargetBuiltin (PR #80279)

AaronBallman wrote: > > The changes seem reasonable to me but I'd feel more comfortable if the > > functionality was also being used (so that we'd get test coverage verifying > > its correctness). Do you think it would be reasonable to include the RISCV > > changes as well? > > Yeah, I separa

[clang] [Clang][TableGen] Add Features to TargetBuiltin (PR #80279)

https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/80279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Add Features to TargetBuiltin (PR #80279)

wangpc-pp wrote: > The changes seem reasonable to me but I'd feel more comfortable if the > functionality was also being used (so that we'd get test coverage verifying > its correctness). Do you think it would be reasonable to include the RISCV > changes as well? Yeah, I separated RISCV chang

[clang] [Clang][TableGen] Add Features to TargetBuiltin (PR #80279)

https://github.com/AaronBallman commented: The changes seem reasonable to me but I'd feel more comfortable if the functionality was also being used (so that we'd get test coverage verifying its correctness). Do you think it would be reasonable to include the RISCV changes as well? https://git

[clang] [Clang][TableGen] Add Features to TargetBuiltin (PR #80279)

wangpc-pp wrote: Ping. https://github.com/llvm/llvm-project/pull/80279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Add Features to TargetBuiltin (PR #80279)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Wang Pengcheng (wangpc-pp) Changes RISCV target will use this parameter, so we need a way to specify it. --- Full diff: https://github.com/llvm/llvm-project/pull/80279.diff 2 Files Affected: - (modified) clang/include/clang/Basic/Built

[clang] [Clang][TableGen] Add Features to TargetBuiltin (PR #80279)

https://github.com/wangpc-pp created https://github.com/llvm/llvm-project/pull/80279 RISCV target will use this parameter, so we need a way to specify it. >From b0728e172ab9d6c139fc665b739d51af20a27bd2 Mon Sep 17 00:00:00 2001 From: Wang Pengcheng Date: Thu, 1 Feb 2024 19:47:46 +0800 Subject: