https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/97208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/97208
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subject: [PATCH 1/9] [Clang] [C23] Implement N2653: u8 strings are char8_t[]
---
@@ -1165,6 +1165,8 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
DefineType("__WCHAR_TYPE__", TI.getWCharType(), Builder);
DefineType("__WINT_TYPE__", TI.getWIntType(), Builder);
DefineTypeSizeAndWidth("__SIG_ATOMIC", TI.getSigAtomicType(), TI, Builder)
https://github.com/cor3ntin approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/97208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, but please wait for @cor3ntin to give a final sign-off before landing.
https://github.com/llvm/llvm-project/pull/97208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
@@ -0,0 +1,29 @@
+// RUN: %clang_cc1 -verify=c23 -std=c23 %s
+// RUN: %clang_cc1 -verify=c17 -std=c17 %s
MitalAshok wrote:
I think I ran the wrong tests then misread some `-E` output... Should be fixed
now (`__STDC_VERSION__ > 202311L` -> `__STDC_VERSION__ >= 20
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/97208
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subject: [PATCH 1/9] [Clang] [C23] Implement N2653: u8 strings are char8_t[]
---
@@ -0,0 +1,29 @@
+// RUN: %clang_cc1 -verify=c23 -std=c23 %s
+// RUN: %clang_cc1 -verify=c17 -std=c17 %s
AaronBallman wrote:
I don't think we should remove the test for stdatomic,h, that's an important
property for us to test and may be papering over a bug here.
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/97208
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subject: [PATCH 1/8] [Clang] [C23] Implement N2653: u8 strings are char8_t[]
---
@@ -0,0 +1,29 @@
+// RUN: %clang_cc1 -verify=c23 -std=c23 %s
+// RUN: %clang_cc1 -verify=c17 -std=c17 %s
MitalAshok wrote:
That still seems to fail on the CI:
```
TEST 'Clang :: C/C23/n2653.c' FAILED
Exit Code: 1
Comman
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/97208
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subject: [PATCH 1/7] [Clang] [C23] Implement N2653: u8 strings are char8_t[]
---
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/97208
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subject: [PATCH 1/6] [Clang] [C23] Implement N2653: u8 strings are char8_t[]
---
@@ -1165,6 +1165,8 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
DefineType("__WCHAR_TYPE__", TI.getWCharType(), Builder);
DefineType("__WINT_TYPE__", TI.getWIntType(), Builder);
DefineTypeSizeAndWidth("__SIG_ATOMIC", TI.getSigAtomicType(), TI, Builder)
@@ -1165,6 +1165,8 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
DefineType("__WCHAR_TYPE__", TI.getWCharType(), Builder);
DefineType("__WINT_TYPE__", TI.getWIntType(), Builder);
DefineTypeSizeAndWidth("__SIG_ATOMIC", TI.getSigAtomicType(), TI, Builder)
@@ -1165,6 +1165,8 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
DefineType("__WCHAR_TYPE__", TI.getWCharType(), Builder);
DefineType("__WINT_TYPE__", TI.getWIntType(), Builder);
DefineTypeSizeAndWidth("__SIG_ATOMIC", TI.getSigAtomicType(), TI, Builder)
@@ -1165,6 +1165,8 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
DefineType("__WCHAR_TYPE__", TI.getWCharType(), Builder);
DefineType("__WINT_TYPE__", TI.getWIntType(), Builder);
DefineTypeSizeAndWidth("__SIG_ATOMIC", TI.getSigAtomicType(), TI, Builder)
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/97208
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subject: [PATCH 1/5] [Clang] [C23] Implement N2653: u8 strings are char8_t[]
---
@@ -104,6 +107,7 @@ typedef _Atomic(long) atomic_long;
typedef _Atomic(unsigned long) atomic_ulong;
typedef _Atomic(long long) atomic_llong;
typedef _Atomic(unsigned long long) atomic_ullong;
+typedef _Atomic(unsigned char) atomic_char8_t;
type
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/97208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -104,6 +107,7 @@ typedef _Atomic(long) atomic_long;
typedef _Atomic(unsigned long) atomic_ulong;
typedef _Atomic(long long) atomic_llong;
typedef _Atomic(unsigned long long) atomic_ullong;
+typedef _Atomic(unsigned char) atomic_char8_t;
type
@@ -1342,8 +1342,10 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
getLockFreeValue(TI.get##Type##Width(), TI));
DEFINE_LOCK_FREE_MACRO(BOOL, Bool);
DEFINE_LOCK_FREE_MACRO(CHAR, Char);
-if (LangOpts.Char8)
- DEFINE_LOCK_F
@@ -104,6 +107,7 @@ typedef _Atomic(long) atomic_long;
typedef _Atomic(unsigned long) atomic_ulong;
typedef _Atomic(long long) atomic_llong;
typedef _Atomic(unsigned long long) atomic_ullong;
+typedef _Atomic(unsigned char) atomic_char8_t;
type
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/97208
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subject: [PATCH 1/3] [Clang] [C23] Implement N2653: u8 strings are char8_t[]
---
@@ -1342,8 +1342,10 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
getLockFreeValue(TI.get##Type##Width(), TI));
DEFINE_LOCK_FREE_MACRO(BOOL, Bool);
DEFINE_LOCK_FREE_MACRO(CHAR, Char);
-if (LangOpts.Char8)
- DEFINE_LOCK_F
@@ -1342,8 +1342,10 @@ static void InitializePredefinedMacros(const TargetInfo
&TI,
getLockFreeValue(TI.get##Type##Width(), TI));
DEFINE_LOCK_FREE_MACRO(BOOL, Bool);
DEFINE_LOCK_FREE_MACRO(CHAR, Char);
-if (LangOpts.Char8)
- DEFINE_LOCK_F
MitalAshok wrote:
CC @AaronBallman
Also the clang-format issues are intentional to fit the style of the
surrounding lines
https://github.com/llvm/llvm-project/pull/97208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7d33d4720f85fa2df7c1307bcc185017b6e4dd25
ef0072d1fc9b14f7ee657fa95f44a686b78b525a --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mital Ashok (MitalAshok)
Changes
https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2653.htm
Closes #97202
---
Full diff: https://github.com/llvm/llvm-project/pull/97208.diff
7 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Mital Ashok (MitalAshok)
Changes
https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2653.htm
Closes #97202
---
Full diff: https://github.com/llvm/llvm-project/pull/97208.diff
7 Files Affected:
- (modified) clang/docs/ReleaseNotes
https://github.com/MitalAshok created
https://github.com/llvm/llvm-project/pull/97208
https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2653.htm
Closes #97202
>From ef0072d1fc9b14f7ee657fa95f44a686b78b525a Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 30 Jun 2024 12:07:54 +0100
Subje
30 matches
Mail list logo
