[clang] [Clang] [NFC] Clarify assume diagnostic (PR #93077)

2024-05-27 Thread Dana Jansens via cfe-commits
danakj wrote: Thanks, this is very good https://github.com/llvm/llvm-project/pull/93077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Clarify assume diagnostic (PR #93077)

2024-05-27 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/93077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Clarify assume diagnostic (PR #93077)

2024-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/93077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Clarify assume diagnostic (PR #93077)

2024-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/93077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Clarify assume diagnostic (PR #93077)

2024-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes Currently, if the argument to `__builtin_assume` and friends contains side-effects, we issue the following diagnostic: ``` source:1:34: warning: the argument to '__builtin_assume' has side effects that will be

[clang] [Clang] [NFC] Clarify assume diagnostic (PR #93077)

2024-05-22 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/93077 Currently, if the argument to `__builtin_assume` and friends contains side-effects, we issue the following diagnostic: ``` :1:34: warning: the argument to '__builtin_assume' has side effects that will be