https://github.com/smanna12 closed
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smanna12 wrote:
Thank you @tahonermann for reviews!
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tahonermann approved this pull request.
Looks good to me, thanks @smanna12!
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/89801
>From 326b428c826e866feb538b9dcd33a9df957f9f69 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Tue, 23 Apr 2024 10:37:01 -0700
Subject: [PATCH 1/2] [Clang] [NFC] Prevent null pointer dereference in
Sirraide wrote:
And moreover, `getParamDecl()` already asserts that the index is in bounds.
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Sirraide commented:
A pr that just adds assertions and nothing else seems like a very weird thing
to do. Moreover, a few lines above in the same function, we return if this
isn’t a copy/move ctor/assignment operator, which always has at least one
parameter; I don’t think it
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
…nctionDefinition
In the lambda function within clang::Sema::InstantiateFunctionDefinition, the
return value of a function that may return null is now checked before
dereferencing to avoid potential null pointer
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
10 matches
Mail list logo
