[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/78566 This removes a default argument that is currently broken in C++23 mode due to `std::default_delete` now being `constexpr`. This is a known problem (see #74963, #59966, #69996, and a couple more), fixing which w

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes This removes a default argument that is currently broken in C++23 mode due to `std::default_delete` now being `constexpr`. This is a known problem (see #74963, #59966, #69996, and a couple more), fixing which will

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread via cfe-commits
Sirraide wrote: CC @AaronBallman https://github.com/llvm/llvm-project/pull/78566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread via cfe-commits
Sirraide wrote: Note sure why that one CI job got cancelled candidly, but I don’t think I can re-run it. https://github.com/llvm/llvm-project/pull/78566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/78566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I'll commit on your behalf once CI comes back green. https://github.com/llvm/llvm-project/pull/78566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/78566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits