https://github.com/yronglin closed
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/88602
>From 9d0656461683c4a6af76aa3990def06b04eb1b0a Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 13 Apr 2024 15:46:36 +0800
Subject: [PATCH 1/3] [Clang] Diagnose apply AST consume actions on LLVM IR
Signed-off
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/88602
>From 9d0656461683c4a6af76aa3990def06b04eb1b0a Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 13 Apr 2024 15:46:36 +0800
Subject: [PATCH 1/3] [Clang] Diagnose apply AST consume actions on LLVM IR
Signed-off
yronglin wrote:
Thanks for your review and confirmation! @AaronBallman @jansvoboda11
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/88602
>From 9d0656461683c4a6af76aa3990def06b04eb1b0a Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 13 Apr 2024 15:46:36 +0800
Subject: [PATCH 1/3] [Clang] Diagnose apply AST consume actions on LLVM IR
Signed-off
https://github.com/jansvoboda11 approved this pull request.
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
> I still have some questions, should we give tips to the user that which
> options cannot apply on LLVM IR files?
I think the diagnostic you've got is reasonable -- these options are CC1
options which are not something we typi
yronglin wrote:
Friendly ping~
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yronglin wrote:
@tbaederr @Sirraide Thanks for your review! I still have some questions, should
we give tips to the user that which options cannot apply on LLVM IR files? Do
we have any precedent or design principles for dealing with mutually exclusive
options?
https://github.com/llvm/llvm-pr
@@ -370,4 +370,7 @@ def warn_missing_symbol_graph_dir : Warning<
"Missing symbol graph output directory, defaulting to working directory">,
InGroup;
+def err_ast_action_on_unparsable_source : Error<
+ "can not apply ast actions to LLVM IR file '%0'">,
yr
@@ -370,4 +370,7 @@ def warn_missing_symbol_graph_dir : Warning<
"Missing symbol graph output directory, defaulting to working directory">,
InGroup;
+def err_ast_action_on_unparsable_source : Error<
+ "can not apply ast actions to LLVM IR file '%0'">,
yr
@@ -370,4 +370,7 @@ def warn_missing_symbol_graph_dir : Warning<
"Missing symbol graph output directory, defaulting to working directory">,
InGroup;
+def err_ast_action_on_unparsable_source : Error<
yronglin wrote:
Agree, I've changed the name to `err_ast
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/88602
>From 9d0656461683c4a6af76aa3990def06b04eb1b0a Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 13 Apr 2024 15:46:36 +0800
Subject: [PATCH 1/2] [Clang] Diagnose apply AST consume actions on LLVM IR
Signed-off
@@ -370,4 +370,7 @@ def warn_missing_symbol_graph_dir : Warning<
"Missing symbol graph output directory, defaulting to working directory">,
InGroup;
+def err_ast_action_on_unparsable_source : Error<
+ "can not apply ast actions to LLVM IR file '%0'">,
tb
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sirraide wrote:
> I'm not sure if this diagnostic information makes sense, do you have any
> suggestions?
If passing a specific command-line to Clang causes it to assert, then I’d say
issuing a diagnostic instead is better, yeah (if this assert was only reachable
by using Clang as a library t
@@ -370,4 +370,7 @@ def warn_missing_symbol_graph_dir : Warning<
"Missing symbol graph output directory, defaulting to working directory">,
InGroup;
+def err_ast_action_on_unparsable_source : Error<
Sirraide wrote:
nit: Maybe a different name for this wou
https://github.com/Sirraide commented:
Not too familiar w/ the driver, but this looks fine to me except for two minor
things.
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
@@ -370,4 +370,7 @@ def warn_missing_symbol_graph_dir : Warning<
"Missing symbol graph output directory, defaulting to working directory">,
InGroup;
+def err_ast_action_on_unparsable_source : Error<
+ "can not apply ast actions to LLVM IR file '%0'">,
Si
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yronglin wrote:
I'm not sure if this diagnostic information makes sense, do you have any
suggestions?
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/88602
>From 9d0656461683c4a6af76aa3990def06b04eb1b0a Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 13 Apr 2024 15:46:36 +0800
Subject: [PATCH] [Clang] Diagnose apply AST consume actions on LLVM IR
Signed-off-by:
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/88602
>From 8ce52d73896d332a1899c59760118a8cf5b620cb Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 13 Apr 2024 15:46:36 +0800
Subject: [PATCH] [Clang] Diagnose apply AST consume actions on LLVM IR
Signed-off-by:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (yronglin)
Changes
Fixes https://github.com/llvm/llvm-project/issues/88522
This PR introduce a new diagnostic to report apply AST consume actions on LLVM
IR.
---
Full diff: https://github.com/llvm/llvm-project/pull/88602.diff
3 Fi
https://github.com/yronglin created
https://github.com/llvm/llvm-project/pull/88602
Fixes https://github.com/llvm/llvm-project/issues/88522
This PR introduce a new diagnostic to report apply AST consume actions on LLVM
IR.
>From a180c067d36b731cbd075651ca4ecd903a643ffa Mon Sep 17 00:00:00 200
25 matches
Mail list logo