[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67981 Summary: The `algorithm` header included here sometimes caused issues when using `libc++` over `libstdc++`. This was primarily because of the order they were included in. This patch just gets rid of this dependen

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Summary: The `algorithm` header included here sometimes caused issues when using `libc++` over `libstdc++`. This was primarily because of the order they were included in. This patch just gets rid of this dependency as it was only used for m

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67981 >From 3ce25920eb83ed2e859050fd24dada7b232e0431 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 2 Oct 2023 07:25:03 -0500 Subject: [PATCH] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

yxsamliu wrote: Did you test it with internal CI? We may need some HIP header changes to avoid regressing existing HIP apps. https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

jhuber6 wrote: > Did you test it with internal CI? We may need some HIP header changes to > avoid regressing existing HIP apps. No, I don't know how to do that. Hopefully people aren't relying on this to be included elsewhere, since its replacement in this single file is pretty striaghtforwar

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/yxsamliu approved this pull request. LGTM. Thanks. It passed internal PSDB https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits