[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/elizabethandrews updated https://github.com/llvm/llvm-project/pull/70224 >From 4ea6d62dab962eba6e52a9fdf7e61b6aac0714fa Mon Sep 17 00:00:00 2001 From: Elizabeth Andrews Date: Mon, 30 Oct 2023 13:07:48 -0700 Subject: [PATCH] [Clang] Fix a crash when using ast-dump=json CXXDed

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -697,6 +697,8 @@ Miscellaneous Clang Crashes Fixed `Issue 64564 `_ - Fixed a crash when an ObjC ivar has an invalid type. See (`#68001 `_) +- Fixed a crash when ``-ast-dum

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/elizabethandrews closed https://github.com/llvm/llvm-project/pull/70224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

elizabethandrews wrote: @tahonermann @AaronBallman does that sound ok to you ? Can I merge this (after a rebase)? https://github.com/llvm/llvm-project/pull/70224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/70224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/tahonermann approved this pull request. I added a minor suggested change for the release note, but this otherwise looks good to me. https://github.com/llvm/llvm-project/pull/70224 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -697,6 +697,8 @@ Miscellaneous Clang Crashes Fixed `Issue 64564 `_ - Fixed a crash when an ObjC ivar has an invalid type. See (`#68001 `_) +- Fixed a crash when ``-ast-dum

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/elizabethandrews created https://github.com/llvm/llvm-project/pull/70224 CXXDeductionGuideDecl inherits from FunctionDecl. For FunctionDecls, the JSONVisitor includes a call to visit NamedDecl in order to provide mangled names in the dump. This did not correctly exclude CXXD

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/elizabethandrews updated https://github.com/llvm/llvm-project/pull/70224 >From 21ecdfb97ff2e8152cec7b4fa3c2fd8913244889 Mon Sep 17 00:00:00 2001 From: Elizabeth Andrews Date: Wed, 25 Oct 2023 09:17:09 -0700 Subject: [PATCH 1/2] [Clang] Fix a crash when using ast-dump=json CX

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, tahonermann wrote: It looks like a reg

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, elizabethandrews wrote: Yes I did. All

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, tahonermann wrote: Hmm, the regex chan

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, elizabethandrews wrote: It looks like

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, AaronBallman wrote: I think we just fo

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -377,6 +377,8 @@ Miscellaneous Clang Crashes Fixed `Issue 64065 `_ - Fixed a crash when check array access on zero-length element. `Issue 64564 `_ +- Fixed a crash when

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -819,6 +819,10 @@ void JSONNodeDumper::VisitNamedDecl(const NamedDecl *ND) { if (VD && VD->hasLocalStorage()) return; +// Do not mangle template deduction guides. +if (const auto DG = dyn_cast(ND)) AaronBallman wrote: ```suggestion if

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/70224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, llvm-beanz wrote: To add a bit of cont

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, tahonermann wrote: Reverting the undes

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/agozillon updated https://github.com/llvm/llvm-project/pull/70224 >From f4559a402d92fd6ab394b586b1c5f3f6d740c3a8 Mon Sep 17 00:00:00 2001 From: Elizabeth Andrews Date: Mon, 30 Oct 2023 13:07:48 -0700 Subject: [PATCH] [Clang] Fix a crash when using ast-dump=json CXXDeductionG

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

https://github.com/elizabethandrews updated https://github.com/llvm/llvm-project/pull/70224 >From f4559a402d92fd6ab394b586b1c5f3f6d740c3a8 Mon Sep 17 00:00:00 2001 From: Elizabeth Andrews Date: Mon, 30 Oct 2023 13:07:48 -0700 Subject: [PATCH] [Clang] Fix a crash when using ast-dump=json CXXDed

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

elizabethandrews wrote: I apologize for the force push. I had a strange Git error I was trying to get rid of. I also squashed my commits for the same reason. It doesn't look like it has helped though. I see the first test bot checking formatting fails with ``` Run python llvm/utils/git/code-f

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

elizabethandrews wrote: I've applied all the review comments. I'm not sure what to do about the failing code format bot though. Should I open a new PR or can I ignore that bot since I've run clang-format locally? https://github.com/llvm/llvm-project/pull/70224

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

llvm-beanz wrote: @elizabethandrews ignore the clang-format failure. The action isn't fetching enough commits from git in some cases which leads to this failure. https://github.com/llvm/llvm-project/pull/70224 ___ cfe-commits mailing list cfe-commits@