https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/89420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/89420
>From a64b08503ae9f49d8b58ee92c226ba19c450ca27 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 19 Apr 2024 19:13:26 +0200
Subject: [PATCH 1/2] [Clang] Fix crash on invalid size in static_assert
message
---
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/89420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/89420
>From a64b08503ae9f49d8b58ee92c226ba19c450ca27 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 19 Apr 2024 19:13:26 +0200
Subject: [PATCH 1/2] [Clang] Fix crash on invalid size in static_assert
message
---
Sirraide wrote:
> The change LGTM but it does need a release note.
Oh, yeah, I somehow forgot about that because I got distracted by the second
bug; will do.
https://github.com/llvm/llvm-project/pull/89420
___
cfe-commits mailing list
cfe-commits@l
cor3ntin wrote:
The change LGTM but it does need a release note
Thanks for fixing that!
https://github.com/llvm/llvm-project/pull/89420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
This addresses two problems observed in #89407 wrt user-defined
`static_assert` messages:
1. In `Expr::EvaluateCharRangeAsString`, we were calling `getExtValue()`
instead of `getZExtValue()`, which would assert if
https://github.com/Sirraide created
https://github.com/llvm/llvm-project/pull/89420
This addresses two problems observed in #89407 wrt user-defined `static_assert`
messages:
1. In `Expr::EvaluateCharRangeAsString`, we were calling `getExtValue()`
instead of `getZExtValue()`, which would asser
