https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/80690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
> Does this fix #67134 as well?
I don't think so, no
https://github.com/llvm/llvm-project/pull/80690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/80690
>From 690a251c4d8df2099b213ba63e9836c2752b5ac1 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 5 Feb 2024 15:42:21 +0100
Subject: [PATCH 1/2] [Clang] Fix looking for immediate calls in default
argument
zyn0217 wrote:
Does this fix https://github.com/llvm/llvm-project/issues/67134 as well?
https://github.com/llvm/llvm-project/pull/80690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/80690
>From 690a251c4d8df2099b213ba63e9836c2752b5ac1 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 5 Feb 2024 15:42:21 +0100
Subject: [PATCH 1/2] [Clang] Fix looking for immediate calls in default
argument
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/80690
>From 77556982a14dc7969a5ab6dc19ce0bfc8a0a763c Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 5 Feb 2024 15:42:21 +0100
Subject: [PATCH 1/2] [Clang] Fix looking for immediate calls in default
argument
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/80690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/80690
>From 77556982a14dc7969a5ab6dc19ce0bfc8a0a763c Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 5 Feb 2024 15:42:21 +0100
Subject: [PATCH 1/2] [Clang] Fix looking for immediate calls in default
argument
@@ -6222,9 +6222,9 @@ struct ImmediateCallVisitor : public
RecursiveASTVisitor {
// Blocks don't support default parameters, and, as for lambdas,
// we don't consider their body a subexpression.
- bool VisitBlockDecl(BlockDecl *B) { return false; }
+ bool VisitBlockDecl
@@ -6198,7 +6198,7 @@ struct ImmediateCallVisitor : public
RecursiveASTVisitor {
bool VisitCallExpr(CallExpr *E) {
if (const FunctionDecl *FD = E->getDirectCallee())
HasImmediateCalls |= FD->isImmediateFunction();
-return RecursiveASTVisitor::VisitStmt(E);
+
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
Due to improper use of RecursiveASTVisitor.
Fixes #80630
---
Full diff: https://github.com/llvm/llvm-project/pull/80690.diff
4 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+2)
- (modified) clan
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/80690
Due to improper use of RecursiveASTVisitor.
Fixes #80630
>From a9e1885ecaf290159a540749552eb9d9d759ef27 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 5 Feb 2024 15:42:21 +0100
Subject: [PATCH] [Clan
12 matches
Mail list logo