https://github.com/michele-scandale closed
https://github.com/llvm/llvm-project/pull/81022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michele-scandale updated
https://github.com/llvm/llvm-project/pull/81022
>From 016d9f113b891abd18a831f30440c77420c79bbc Mon Sep 17 00:00:00 2001
From: Michele Scandale
Date: Mon, 4 Mar 2024 10:23:26 -0800
Subject: [PATCH] [Clang] Fixes of builtins definitions after PR
https://github.com/AaronBallman approved this pull request.
LGTM, thank you for the fix!
https://github.com/llvm/llvm-project/pull/81022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
michele-scandale wrote:
@AaronBallman, ping.
https://github.com/llvm/llvm-project/pull/81022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michele-scandale wrote:
@AaronBallman, ping.
https://github.com/llvm/llvm-project/pull/81022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michele-scandale wrote:
Added the change to restore `__addressof` to the prior definition. To do that I
have to introduce the `FunctionWithoutBuiltinPrefix` attribute (expanded to
`f`) -- this is implicitly added for builtins deriving from `LibBuiltin`, but
for this case we are expecting to
https://github.com/michele-scandale updated
https://github.com/llvm/llvm-project/pull/81022
>From 38542367553bf6b603eba199591dbbf14a9ca26e Mon Sep 17 00:00:00 2001
From: Michele Scandale
Date: Fri, 16 Feb 2024 13:20:55 -0800
Subject: [PATCH] [Clang] Fixes of builtins definitions after PR
michele-scandale wrote:
> > There are still some differences that I haven't addressed here as they
> > might be ok to have:
> > ```
> > * `__builtin_rint{,f,l}` were defined with the `const` attribute, now they
> > use the `const when FP exceptions are ignored` -- this seems due to the
> >
https://github.com/AaronBallman approved this pull request.
LGTM, these fixes all look correct to me. The only thing that seemed somewhat
off was with the `sync` functions taking a pointer to a `volatile` (that's not
documented in GCC's docs, but I think the signature does make sense). Thank
AaronBallman wrote:
> There are still some differences that I haven't addressed here as they might
> be ok to have:
>
> * `__builtin_rint{,f,l}` were defined with the `const` attribute, now
> they use the `const when FP exceptions are ignored` -- this seems due to the
> definition of
https://github.com/michele-scandale edited
https://github.com/llvm/llvm-project/pull/81022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
11 matches
Mail list logo
