[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread via cfe-commits
mikaoP wrote: Maybe the discussing topic is, as you said, if we allow specifying `x86_64` as target. Or fixing the rpath format if we support that. https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread via cfe-commits
mikaoP wrote: Maybe I'm not getting what you say. I see that when you use `-fopenmp-targets=x86-64-unknown-linux-gnu` then no gcc command is issued. In any case, a clang command is run with `-rpath ` or `-Wl,-rpath,`. The last is what this patch does only for CPU offloading. I guess that does

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: If you really need this, perhaps you can check if the Triple will invoke the fallback toolchain or something? Would be a lack of vendor in the Triple. https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-comm

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I thought that clang accepted `-rpath `? I see that format when I try > > CPU offloading. > > Yeah, but when running `--target=x86_64` and underlying gcc command is issued > and complains about `-rpath ` Oh, I see. When using `-fopenmp-targets=x86_64` it goes through the de

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread via cfe-commits
mikaoP wrote: > I thought that clang accepted `-rpath `? I see that format when I try > CPU offloading. Yeah, but when running `--target=x86_64` and underlying gcc command is issued and complains about `-rpath ` https://github.com/llvm/llvm-project/pull/95763 _

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I remember intentionally using the clang argument format instead of `-Wl,-rpath,` because the `-Wl` format would try to forward it to things like `nvlink` which don't support it. https://github.com/llvm/llvm-project/pull/95763 ___ cfe-

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread via cfe-commits
mikaoP wrote: Ah, right. I'll remove the folder then https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: The tests use an option that causes nothing to actually run, so it only uses the filename. https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread via cfe-commits
mikaoP wrote: Ah, since in the test I had to put an rpath I though that for the test we needed a valid folder https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: What is this? https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: I thought that clang accepted `-rpath `? I see that format when I try CPU offloading. https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Forward -rpath flag to the correct format in CPU offloading (PR #95763)

2024-06-17 Thread via cfe-commits
https://github.com/mikaoP edited https://github.com/llvm/llvm-project/pull/95763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits