[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

bwendling wrote: @nickdesaulniers and @alexfh Any comments? :-) https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

@@ -282,7 +282,7 @@ class CorrectionCandidateCallback { public: static const unsigned InvalidDistance = TypoCorrection::InvalidDistance; - explicit CorrectionCandidateCallback(IdentifierInfo *Typo = nullptr, + explicit CorrectionCandidateCallback(const IdentifierInfo *Typo

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/AaronBallman approved this pull request. LGTM! Thank you for the cleanup on the diagnostics, too. :-) https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/68750 >From b7b0c40542589e9c54c21140dbb5b163dd8ffc7b Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Oct 2023 17:55:49 -0700 Subject: [PATCH 1/4] [Clang] Implement the 'counted_by' attribute The 'counted_b

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

bwendling wrote: @AaronBallman I just added a patch that modifies the diagnostics to be more in line with what you wanted. PTAL. https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/68750 >From b7b0c40542589e9c54c21140dbb5b163dd8ffc7b Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Oct 2023 17:55:49 -0700 Subject: [PATCH 1/3] [Clang] Implement the 'counted_by' attribute The 'counted_b

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/oskarwirga commented: I've reviewed the admittedly limited sections I'm familiar with and LGTM! This is great work :) https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/68750 >From b7b0c40542589e9c54c21140dbb5b163dd8ffc7b Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Oct 2023 17:55:49 -0700 Subject: [PATCH 1/2] [Clang] Implement the 'counted_by' attribute The 'counted_b

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3a6cc52fe3501b2b7b3aabdff305a18122c9e0db b7b0c40542589e9c54c21140dbb5b163dd8ffc7b --

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

bwendling wrote: And @AaronBallman, I haven't forgotten my promise to change the diagnostics. I've been on vacation, and it's become trickier to get them to work the other way than I had first thought. The change is coming soon though. https://github.com/llvm/llvm-project/pull/68750 __

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

bwendling wrote: This is identical to the original change (9a954c693573281407f6ee3f4eb1b16cc545033d), but with a fix for the issue @alexfh discovered (https://github.com/llvm/llvm-project/commit/9a954c693573281407f6ee3f4eb1b16cc545033d#commitcomment-129529574). The change is on lines 473-475

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Bill Wendling (bwendling) Changes The 'counted_by' attribute is used on flexible array members. The argument for the attribute is the name of the field member in the same structure holding the count of elements in the flexible arr

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/68750 The 'counted_by' attribute is used on flexible array members. The argument for the attribute is the name of the field member in the same structure holding the count of elements in the flexible array. This info