[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-26 Thread Shafik Yaghmour via cfe-commits
@@ -542,3 +542,46 @@ void foo(C c) { } } + + +namespace GH69838 { +struct S { + S(this auto ) {} // expected-error {{an explicit object parameter cannot appear in a constructor}} + virtual void f(this S self) {} // expected-error {{an explicit object parameter cannot

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/70018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. DR test part of this PR looks fine to me. https://github.com/llvm/llvm-project/pull/70018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70018 >From c6edb59fe6283a751445d44724465eaad5d287cb Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 24 Oct 2023 11:20:30 +0200 Subject: [PATCH] [Clang] Mark declarators invalid in the presence of

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/70018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread via cfe-commits
cor3ntin wrote: > Is there no release note because there is no release that supports explicit > object parameters yet? Exactly, yes! https://github.com/llvm/llvm-project/pull/70018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon commented: Is there no release note because there is no release that supports explicit object parameters yet? https://github.com/llvm/llvm-project/pull/70018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes To avoid crashes later in sema. Fixes #69962 Fixes #69838 --- Full diff: https://github.com/llvm/llvm-project/pull/70018.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaDeclCXX.cpp (+6-1) -

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/70018 To avoid crashes later in sema. Fixes #69962 Fixes #69838 >From 4810d5c8d9d9ec95300c3b684fe3ff88fdd05351 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 24 Oct 2023 11:20:30 +0200 Subject: [PATCH]