[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

@@ -0,0 +1,28 @@ +// From https://github.com/llvm/llvm-project/issues/77953 +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/a.cppm -o %t/a.pcm +// RUN: %clang_cc1 -std=c++20 -fmodule-file=a=%t/a.pcm

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

@@ -0,0 +1,28 @@ +// From https://github.com/llvm/llvm-project/issues/77953 +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/a.cppm -o %t/a.pcm +// RUN: %clang_cc1 -std=c++20 -fmodule-file=a=%t/a.pcm

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/78139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/78139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

@@ -1259,6 +1259,40 @@ static bool IsOverloadOrOverrideImpl(Sema , FunctionDecl *New, if ((OldTemplate == nullptr) != (NewTemplate == nullptr)) return true; + // Is the function New an overload of the function Old? + QualType OldQType =

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/78139 >From e0eb639c9830599e184aec428164de0b2fb38b71 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 15 Jan 2024 10:17:13 +0100 Subject: [PATCH 1/2] [Clang] Only compare template params of potential

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

@@ -24,11 +24,6 @@ class Y { void k() &&; // expected-error{{cannot overload a member function with ref-qualifier '&&' with a member function without a ref-qualifier}} }; -struct GH76358 { cor3ntin wrote: Completely accidental, i did not notice...

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

@@ -24,11 +24,6 @@ class Y { void k() &&; // expected-error{{cannot overload a member function with ref-qualifier '&&' with a member function without a ref-qualifier}} }; -struct GH76358 { AaronBallman wrote: Why remove this test?

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

@@ -1259,6 +1259,40 @@ static bool IsOverloadOrOverrideImpl(Sema , FunctionDecl *New, if ((OldTemplate == nullptr) != (NewTemplate == nullptr)) return true; + // Is the function New an overload of the function Old? + QualType OldQType =

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/78139 >From e0eb639c9830599e184aec428164de0b2fb38b71 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 15 Jan 2024 10:17:13 +0100 Subject: [PATCH] [Clang] Only compare template params of potential overload

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 08e4386a2c91befabab317498b50ffc326ff4eae e5be422e1d27a9e1066777e9114bba510e5195bb --

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: cor3ntin (cor3ntin) Changes Fixes a regression from 69066ab3 in which we compared the template lists of potential overloads before checkings their declaration contexts. This would cause a crash when doing constraint

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Fixes a regression from 69066ab3 in which we compared the template lists of potential overloads before checkings their declaration contexts. This would cause a crash when doing constraint substitution as

[clang] [Clang] Only compare template params of potential overload after checking their decl context (PR #78139)

https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/78139 Fixes a regression from 69066ab3 in which we compared the template lists of potential overloads before checkings their declaration contexts. This would cause a crash when doing constraint substitution as