[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm closed https://github.com/llvm/llvm-project/pull/78258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Matthew Devereau via cfe-commits
@@ -136,10 +136,10 @@ defm SVWRITE_ZA128 : ZAWrite<"za128", "csilUcUsUiUlhbfd", "aarch64_sme_writeq", let TargetGuard = "sme" in { def SVZERO_MASK_ZA : SInst<"svzero_mask_za", "vi", "", MergeNone, "aarch64_sme_zero", - [IsOverloadNone,

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau edited https://github.com/llvm/llvm-project/pull/78258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau approved this pull request. https://github.com/llvm/llvm-project/pull/78258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -342,331 +342,331 @@ let TargetGuard = "sme2" in { // let TargetGuard = "sme2" in { - def SVSMOPA : Inst<"svmopa_za32[_{d}]_m", "viPPdd", "s", MergeNone, "aarch64_sme_smopa_za32", [IsSharedZA, IsStreaming], [ImmCheck<0, ImmCheck0_3>]>; - def SVUSMOPA :

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -136,10 +136,10 @@ defm SVWRITE_ZA128 : ZAWrite<"za128", "csilUcUsUiUlhbfd", "aarch64_sme_writeq", let TargetGuard = "sme" in { def SVZERO_MASK_ZA : SInst<"svzero_mask_za", "vi", "", MergeNone, "aarch64_sme_zero", - [IsOverloadNone,

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -342,331 +342,331 @@ let TargetGuard = "sme2" in { // let TargetGuard = "sme2" in { - def SVSMOPA : Inst<"svmopa_za32[_{d}]_m", "viPPdd", "s", MergeNone, "aarch64_sme_smopa_za32", [IsSharedZA, IsStreaming], [ImmCheck<0, ImmCheck0_3>]>; - def SVUSMOPA :

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -3005,6 +3005,15 @@ enum ArmStreamingType { ArmStreamingOrSVE2p1 }; +enum ArmSMEState : unsigned { + ArmNoState = 0, + + ArmInZA = 0b01, + ArmOutZA = 0b10, + ArmInOutZA = 0b11, + ArmZAMask = 0b11, sdesmalen-arm wrote: I'm not really convinced

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -1720,21 +1720,29 @@ void SVEEmitter::createBuiltinZAState(raw_ostream ) { for (auto *R : RV) createIntrinsic(R, Defs); - std::map> DefsZAState; - - uint64_t IsSharedZAFlag = getEnumValueForFlag("IsSharedZA"); + std::map> IntrinsicsPerState; for (auto : Defs)

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm updated https://github.com/llvm/llvm-project/pull/78258 >From 545866d530ebeab04384ce85e61a7eb29d343167 Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Mon, 15 Jan 2024 16:06:36 + Subject: [PATCH 1/2] [Clang] Refactor diagnostics for SME builtins. The

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-18 Thread Matthew Devereau via cfe-commits
@@ -342,331 +342,331 @@ let TargetGuard = "sme2" in { // let TargetGuard = "sme2" in { - def SVSMOPA : Inst<"svmopa_za32[_{d}]_m", "viPPdd", "s", MergeNone, "aarch64_sme_smopa_za32", [IsSharedZA, IsStreaming], [ImmCheck<0, ImmCheck0_3>]>; - def SVUSMOPA :

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-18 Thread Matthew Devereau via cfe-commits
@@ -1720,21 +1720,29 @@ void SVEEmitter::createBuiltinZAState(raw_ostream ) { for (auto *R : RV) createIntrinsic(R, Defs); - std::map> DefsZAState; - - uint64_t IsSharedZAFlag = getEnumValueForFlag("IsSharedZA"); + std::map> IntrinsicsPerState; for (auto : Defs)

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-18 Thread Matthew Devereau via cfe-commits
@@ -3005,6 +3005,15 @@ enum ArmStreamingType { ArmStreamingOrSVE2p1 }; +enum ArmSMEState : unsigned { + ArmNoState = 0, + + ArmInZA = 0b01, + ArmOutZA = 0b10, + ArmInOutZA = 0b11, + ArmZAMask = 0b11, MDevereau wrote: ```suggestion ArmZAMask =

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-18 Thread Matthew Devereau via cfe-commits
@@ -102,3 +102,8 @@ svint8_t missing_za(svint8_t zd, svbool_t pg, uint32_t slice_base) __arm_streami // expected-warning@+1 {{builtin call is not valid when calling from a function without active ZA state}} return svread_hor_za8_s8_m(zd, pg, 0, slice_base); } +

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-18 Thread Matthew Devereau via cfe-commits
@@ -1720,21 +1720,29 @@ void SVEEmitter::createBuiltinZAState(raw_ostream ) { for (auto *R : RV) createIntrinsic(R, Defs); - std::map> DefsZAState; - - uint64_t IsSharedZAFlag = getEnumValueForFlag("IsSharedZA"); + std::map> IntrinsicsPerState; for (auto : Defs)

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-18 Thread Matthew Devereau via cfe-commits
@@ -136,10 +136,10 @@ defm SVWRITE_ZA128 : ZAWrite<"za128", "csilUcUsUiUlhbfd", "aarch64_sme_writeq", let TargetGuard = "sme" in { def SVZERO_MASK_ZA : SInst<"svzero_mask_za", "vi", "", MergeNone, "aarch64_sme_zero", - [IsOverloadNone,

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-18 Thread Kerry McLaughlin via cfe-commits
@@ -342,331 +342,331 @@ let TargetGuard = "sme2" in { // let TargetGuard = "sme2" in { - def SVSMOPA : Inst<"svmopa_za32[_{d}]_m", "viPPdd", "s", MergeNone, "aarch64_sme_smopa_za32", [IsSharedZA, IsStreaming], [ImmCheck<0, ImmCheck0_3>]>; - def SVUSMOPA :

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sander de Smalen (sdesmalen-arm) Changes The arm_sme.td file was still using `IsSharedZA` and `IsPreservesZA`, which should be changed to match the new state attributes added in #76971. This patch adds `IsInZA`, `IsOutZA` and `IsInOutZA`

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-16 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm created https://github.com/llvm/llvm-project/pull/78258 The arm_sme.td file was still using `IsSharedZA` and `IsPreservesZA`, which should be changed to match the new state attributes added in #76971. This patch adds `IsInZA`, `IsOutZA` and `IsInOutZA` as the