[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

@@ -2261,8 +2261,17 @@ bool Lexer::LexRawStringLiteral(Token , const char *CurPtr, unsigned PrefixLen = 0; - while (PrefixLen != 16 && isRawStringDelimBody(CurPtr[PrefixLen])) + while (PrefixLen != 16 && isRawStringDelimBody(CurPtr[PrefixLen])) { ++PrefixLen; +

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

@@ -2261,8 +2261,17 @@ bool Lexer::LexRawStringLiteral(Token , const char *CurPtr, unsigned PrefixLen = 0; - while (PrefixLen != 16 && isRawStringDelimBody(CurPtr[PrefixLen])) + while (PrefixLen != 16 && isRawStringDelimBody(CurPtr[PrefixLen])) { ++PrefixLen; +

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

cor3ntin wrote: Indeed, thanks for catching that! https://github.com/llvm/llvm-project/pull/93216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

amilendra wrote: Hello @cor3ntin This patch has resulted in strings that were previously rejected are now accepted by the compiler. https://godbolt.org/z/c1jcGv76z ``` int main() { (void) R"\t()\t"; (void) R"\f()\f"; (void) R"\n()\n"; (void) R"\v()\v"; } ``` My reasoning is that

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

@@ -152,16 +151,17 @@ LLVM_READONLY inline bool isHexDigit(unsigned char c) { /// Note that '_' is both a punctuation character and an identifier character! LLVM_READONLY inline bool isPunctuation(unsigned char c) { using namespace charinfo; - return (InfoTable[c] &

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

@@ -152,16 +151,17 @@ LLVM_READONLY inline bool isHexDigit(unsigned char c) { /// Note that '_' is both a punctuation character and an identifier character! LLVM_READONLY inline bool isPunctuation(unsigned char c) { using namespace charinfo; - return (InfoTable[c] &

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/93216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/AaronBallman approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/93216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/93216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/93216 >From 556c622275c630b74c0f9000c5c599ff665595e1 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 23 May 2024 18:45:58 +0200 Subject: [PATCH 1/2] [Clang] allow `` `@$ `` in raw string delimiters in C++26

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/93216 >From 556c622275c630b74c0f9000c5c599ff665595e1 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 23 May 2024 18:45:58 +0200 Subject: [PATCH 1/2] [Clang] allow `` `@$ `` in raw string delimiters in C++26

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/93216 >From 556c622275c630b74c0f9000c5c599ff665595e1 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 23 May 2024 18:45:58 +0200 Subject: [PATCH 1/2] [Clang] allow `` `@$ `` in raw string delimiters in C++26

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/93216 >From 556c622275c630b74c0f9000c5c599ff665595e1 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 23 May 2024 18:45:58 +0200 Subject: [PATCH 1/2] [Clang] allow `` `@$ `` in raw string delimiters in C++26

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

@@ -111,6 +111,14 @@ def warn_cxx98_compat_raw_string_literal : Warning< "raw string literals are incompatible with C++98">, InGroup, DefaultIgnore; +def warn_cxx26_compat_raw_string_literal_character_set : Warning< + "'%0'in a raw string literal delimiter is

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

@@ -111,6 +111,14 @@ def warn_cxx98_compat_raw_string_literal : Warning< "raw string literals are incompatible with C++98">, InGroup, DefaultIgnore; +def warn_cxx26_compat_raw_string_literal_character_set : Warning< + "'%0'in a raw string literal delimiter is

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/shafik commented: LGTM but I would like Tom or Aaron to also take a look https://github.com/llvm/llvm-project/pull/93216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 558cb29feae6011beb2d384b1ef094bb9f7f2c27 556c622275c630b74c0f9000c5c599ff665595e1 --

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/93216 >From 556c622275c630b74c0f9000c5c599ff665595e1 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 23 May 2024 18:45:58 +0200 Subject: [PATCH] [Clang] allow `` `@$ `` in raw string delimiters in C++26 And

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes And as an extension in older language modes. Per https://eel.is/c++draft/lex.string#nt:d-char Fixes #93130 --- Full diff: https://github.com/llvm/llvm-project/pull/93216.diff 6 Files Affected: - (modified)

[clang] [Clang] allow `` `@$ `` in raw string delimiters in C++26 (PR #93216)

https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/93216 And as an extension in older language modes. Per https://eel.is/c++draft/lex.string#nt:d-char Fixes #93130 >From fa233d79d3d27ba5c8836d971e2a8fd920cda997 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: