[clang] [Clang] use colon char instead of token name (PR #144068)

https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

rkirsling wrote: Oh oops! Thanks for the correction. https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

rkirsling wrote: I believe I'd need somebody to hit the merge button for me regardless, so I think we can just merge whichever one and close the other. 😅 The two approaches are mostly the same, I just figured that the surrounding code was consistent in using a literal `":"`, while there doesn'

[clang] [Clang] use colon char instead of token name (PR #144068)

a-tarasyuk wrote: @rkirsling, this test does not verify the fix https://github.com/llvm/llvm-project/pull/144069/files#diff-b87b117875d2e75dc1ef39535756591a688853bbeb7f83e5b4df6bafca111fa0R239-R241 [switch-recovery.cpp](https://github.com/llvm/llvm-project/blob/cf6ae065a042aae6324b28e99628c40bc

[clang] [Clang] use colon char instead of token name (PR #144068)

https://github.com/Fznamznon approved this pull request. https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

a-tarasyuk wrote: > Ohh, you beat me by a minute. 😆 I suppose > https://github.com/llvm/llvm-project/pull/144069 could be closed then. You can copy the tests/changes from this PR into yours — I'll close this one. https://github.com/llvm/llvm-project/pull/144068

[clang] [Clang] use colon char instead of token name (PR #144068)

rkirsling wrote: Ohh, you beat me by a minute. 😆 I can close #144069 then. https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/144068 >From a83afe5aca4f192f378ef4b99477103b23991026 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Fri, 13 Jun 2025 15:28:20 +0300 Subject: [PATCH 1/2] [Clang] use colon char instead of token name --- c

[clang] [Clang] use colon char instead of token name (PR #144068)

@@ -836,8 +836,7 @@ StmtResult Parser::ParseCaseStatement(ParsedStmtContext StmtCtx, Diag(ExpectedLoc, diag::err_expected_after) << "'case'" << tok::colon - << FixItHint::CreateInsertion(ExpectedLoc, -tok::getTo

[clang] [Clang] use colon char instead of token name (PR #144068)

https://github.com/Fznamznon commented: Can we add a test? https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

a-tarasyuk wrote: /cc @rkirsling https://github.com/llvm/llvm-project/pull/144068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use colon char instead of token name (PR #144068)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes regression of https://github.com/llvm/llvm-project/pull/143460/files#r2144925614 --- Full diff: https://github.com/llvm/llvm-project/pull/144068.diff 1 Files Affected: - (modified) clang/lib/Pars

[clang] [Clang] use colon char instead of token name (PR #144068)

https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/144068 Fixes regression of https://github.com/llvm/llvm-project/pull/143460/files#r2144925614 >From a83afe5aca4f192f378ef4b99477103b23991026 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Fri, 13 Jun 2025