https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/91637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 approved this pull request.
https://github.com/llvm/llvm-project/pull/91637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yxsamliu wrote:
> There's some code in the `clang-linker-wrapper` that creates the
> offloadbundler format for HIP offloading. I think it and the tests use
> `hipv4` which we could presumably remove now?
yes. I updated linker wrapper to use hip- instead of hipv4-
https://github.com/llvm/llvm-
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/91637
>From 21ab5258598961184b175c3b373ae5bf4cb8b914 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 9 May 2024 14:11:55 -0400
Subject: [PATCH] [ClangOffloadBundler] make hipv4 and hip compatible
The dist
https://github.com/jhuber6 commented:
There's some code in the `clang-linker-wrapper` that creates the offloadbundler
format for HIP offloading. I think it and the tests use `hipv4` which we could
presumably remove now?
https://github.com/llvm/llvm-project/pull/91637
__
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
The distinction between the hip and hipv4 offload kinds is historically
based. Originally, these designations might have indicated different versions
of the code object ABI (Application Binary Interfac
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/91637
The distinction between the hip and hipv4 offload kinds is historically
based. Originally, these designations might have indicated different versions
of the code object ABI (Application Binary Interface). How