[clang] [Coverage] Map regions from system headers (PR #76950)

chapuni wrote: I have restored this since our issue has been resolved in #80292. https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Map regions from system headers (PR #76950)

chapuni wrote: This works for me if #78033 is fixed or reverted. https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Map regions from system headers (PR #76950)

mhaehnel wrote: Your revert just masks the underlying issue. What you do now is that you *can* specify `-system-headers-coverage` but the compiler will not actually provide coverage data for system headers because the flag is ignored. So specifying the switch becomes meaningless. https://gi

[clang] [Coverage] Map regions from system headers (PR #76950)

chapuni wrote: Excuse me, I've reverted this. I posted a reduced testcase in #78920. Reproducible w/o `-fcoverage-mcdc`. https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [Coverage] Map regions from system headers (PR #76950)

chapuni wrote: I haven't had a reduced testcase for it, though. I expect it reproducible with `-fcoverage-mcdc -mllvm -system-headers-coverage` to build `LLVMSupport`. `clangCodeGen` will crash. (`llvm-cov` crashes w/o `system-headers-coverage`) https://github.com/llvm/llvm-project/pull/76950

[clang] [Coverage] Map regions from system headers (PR #76950)

chapuni wrote: Seems this causes the crash with `-fcoverage-mcdc -mllvm -system-headers-coverage`. Investigating. See also #78920. https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [Coverage] Map regions from system headers (PR #76950)

https://github.com/ManuelvOK updated https://github.com/llvm/llvm-project/pull/76950 >From 1762695354c172bb35b97017b2706d8d476121e1 Mon Sep 17 00:00:00 2001 From: Manuel Kalettka Date: Wed, 3 Jan 2024 16:59:00 +0100 Subject: [PATCH] [Coverage] Map regions from system headers In 2155195, the "s

[clang] [Coverage] Map regions from system headers (PR #76950)

ManuelvOK wrote: Thanks for the approval. I unfortunately don't have the credentials to merge this change. Can you do this, @petrhosek ? https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [Coverage] Map regions from system headers (PR #76950)

https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Map regions from system headers (PR #76950)

https://github.com/mhaehnel approved this pull request. LGTM Disclaimer: I am a co-worker of the change author and discussed the change also offline. https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [Coverage] Map regions from system headers (PR #76950)

https://github.com/ManuelvOK edited https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Map regions from system headers (PR #76950)

https://github.com/ManuelvOK edited https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Map regions from system headers (PR #76950)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (ManuelvOK) Changes In 2155195, the "system-headers-coverage" option has been added but not used in all necessary places. --- Full diff: https://github.com/llvm/llvm-project/pull/76950.diff 2 Files Affected: - (modified) c

[clang] [Coverage] Map regions from system headers (PR #76950)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [Coverage] Map regions from system headers (PR #76950)

https://github.com/ManuelvOK created https://github.com/llvm/llvm-project/pull/76950 In 2155195, the "system-headers-coverage" option has been added but not used in all necessary places. >From 593b9db7dcbb814ddac3c77b462d04400cfa77a8 Mon Sep 17 00:00:00 2001 From: Manuel Kalettka Date: Wed, 3