https://github.com/ZijunZhaoCCK closed
https://github.com/llvm/llvm-project/pull/80783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/80783
>From 84506beecc20a064a5c895cf5c04135118da6606 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Tue, 6 Feb 2024 01:58:58 +
Subject: [PATCH 1/3] [Driver] Check the environment version except wasm case.
---
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/80783
>From 84506beecc20a064a5c895cf5c04135118da6606 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Tue, 6 Feb 2024 01:58:58 +
Subject: [PATCH 1/2] [Driver] Check the environment version except wasm case.
---
@@ -14,3 +14,18 @@
// RUN: FileCheck --check-prefix=CHECK-TARGET %s
MaskRay wrote:
Sorry, I didn't see the
`[clang/test/Driver/invalid-version.cpp](https://github.com/llvm/llvm-project/pull/80783/files#diff-6c20c1f9b36f569382ab3c9daebb660db0eb8666af4beaf59813
@@ -14,3 +14,18 @@
// RUN: FileCheck --check-prefix=CHECK-TARGET %s
// CHECK-TARGET: "aarch64-unknown-linux-android31"
+
+// RUN: not %clang --target=armv7-linux-gnuS -c %s -### 2>&1 | \
+// RUN: FileCheck --check-prefix=CHECK-ERROR2 %s
+
+// CHECK-ERROR2: error: version '
https://github.com/MaskRay approved this pull request.
LGTM with glandium's suggestion.
https://github.com/llvm/llvm-project/pull/80783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/80783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1443,16 +1443,18 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
const ToolChain &TC = getToolChain(
*UArgs, computeTargetTriple(*this, TargetTriple, *UArgs));
- // Check if the environment version is valid.
- llvm::Triple Triple = TC.getTriple();
-
MaskRay wrote:
wasm tests in android-* seem weird. A wasm file should be used
https://github.com/llvm/llvm-project/pull/80783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: None (ZijunZhaoCCK)
Changes
Add isWasm() check for here:
https://github.com/llvm/llvm-project/pull/78655#issuecomment-1928075569
---
Full diff: https://github.com/llvm/llvm-project/pull/80783.diff
1 Files Affected:
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (ZijunZhaoCCK)
Changes
Add isWasm() check for here:
https://github.com/llvm/llvm-project/pull/78655#issuecomment-1928075569
---
Full diff: https://github.com/llvm/llvm-project/pull/80783.diff
1 Files Affected:
- (modified) clang/l
https://github.com/ZijunZhaoCCK created
https://github.com/llvm/llvm-project/pull/80783
Add isWasm() check for here:
https://github.com/llvm/llvm-project/pull/78655#issuecomment-1928075569
>From 84506beecc20a064a5c895cf5c04135118da6606 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Tue, 6 Feb
12 matches
Mail list logo