[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 brad0 wrote: Done. https://github.com/llvm/llvm-project/pull/69809

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/69809 >From c50e534591cadcd41759608bffdda3a01a304ea7 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 18:41:03 -0400 Subject: [PATCH] [Driver] Clean up unused architecture related bits for *BSD's - FreeBSD

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -247,12 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple &Triple, switch (os) { case llvm::Triple::Linux: return std::make_unique>(Triple, Opts); -case llvm::Triple::FreeBSD: brad0 wrote: Ya, even with support being removed I d

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 emaste wrote: Maybe worth noting that in the commit message too but either w

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/emaste edited https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 brad0 wrote: I already removed the other OS specific tests as I enabled IAS

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -163,9 +163,9 @@ // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-mfpu=softvfp" // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-matpcs" -// RUN: %clang --target=sparc-unknown-freebsd -### %s -fpic -no-integrated-as 2>&1 \ -// RUN: | FileCheck --check-prefix=CHECK-SPARC-PIE %s -// CHECK-SPARC-P

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

MaskRay wrote: Thanks for the cleanup! https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/emaste commented: overall looks fine, no objection from FreeBSD. one open question. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 emaste wrote: why is this part here (before sparc64 is removed from FreeBSD)

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -163,9 +163,9 @@ // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-mfpu=softvfp" // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-matpcs" -// RUN: %clang --target=sparc-unknown-freebsd -### %s -fpic -no-integrated-as 2>&1 \ -// RUN: | FileCheck --check-prefix=CHECK-SPARC-PIE %s -// CHECK-SPARC-P

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

@@ -247,12 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple &Triple, switch (os) { case llvm::Triple::Linux: return std::make_unique>(Triple, Opts); -case llvm::Triple::FreeBSD: emaste wrote: OK - there are no supported FreeBSD re

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

brad0 wrote: ping. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a63dc79d113915048c932eca7732838206898e9a d490fc90f49d83d7b5ec26086c59a3f512b552ba --

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

brad0 wrote: Fix a typo in the commit message. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits