Kewen12 wrote:
Thanks again for your help @lenary
https://github.com/llvm/llvm-project/pull/144582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lenary closed
https://github.com/llvm/llvm-project/pull/144582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lenary wrote:
I'm going to land this, as I'm taking "I'm aligned with this fix" as approval
from garvit (I know he's in a different time zone, which may mean he's logged
off for the night)
https://github.com/llvm/llvm-project/pull/144582
___
cfe-comm
Kewen12 wrote:
Thanks for this quick fix!
Hi @quic-garvgupt, could you please help approve this PR if it looks good to
you. It would be helpful to unblock our bots and downstream. Thanks!
https://github.com/llvm/llvm-project/pull/144582
___
cfe-com
quic-garvgupt wrote:
> `ToolChain::UnwindLibType ToolChain::GetUnwindLibType( const ArgList &Args)
> const { if (unwindLibType) return *unwindLibType;
>
> const Arg *A = Args.getLastArg(options::OPT_unwindlib_EQ); StringRef LibName
> = A ? A->getValue() : CLANG_DEFAULT_UNWINDLIB;`
>
> If --un
quic-garvgupt wrote:
`ToolChain::UnwindLibType ToolChain::GetUnwindLibType(
const ArgList &Args) const {
if (unwindLibType)
return *unwindLibType;
const Arg *A = Args.getLastArg(options::OPT_unwindlib_EQ);
StringRef LibName = A ? A->getValue() : CLANG_DEFAULT_UNWINDLIB;`
I
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Sam Elliott (lenary)
Changes
The openmp-offload-amdgpu-runtime-2 bot specifies default rtlib of compiler-rt,
but default unwindlib of libgcc. Change the tests to accept that there may be
`"--as-needed" "-
https://github.com/lenary edited
https://github.com/llvm/llvm-project/pull/144582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
