[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-15 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#140044 https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-15 Thread Rainer Orth via cfe-commits
rorth wrote: /cherry-pick e71c8ea3cc73c8f7b0382468f355a254166d3a72 https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-15 Thread Rainer Orth via cfe-commits
rorth wrote: Drats, I'd hoped the markup would inhibit the cherry pick directive from being picked up. I've now dropped the patch into local LLVM 20.1.5 builds on both `amd64-pc-solaris2.11` and `sparcv9-sun-solaris2.11`. It applied cleanly and introduced no regressions. I'll try a regular

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-10 Thread via cfe-commits
llvmbot wrote: Failed to cherry-pick: ` https://github.com/llvm/llvm-project/actions/runs/14947694098 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare) https://github.com/llvm/ll

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-10 Thread Rainer Orth via cfe-commits
rorth wrote: No. However, I got an [error](https://github.com/llvm/llvm-project/actions/runs/14798017932) for the `/cherry-pick` that looks like some weird internal error to me, not a failed merge attempt or some such. https://github.com/llvm/llvm-project/pull/137141

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-10 Thread Tom Stellard via cfe-commits
tstellar wrote: Was there a backport PR created for this change? https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-02 Thread Rainer Orth via cfe-commits
rorth wrote: This patch is required to build `flang` on Solaris/amd64. Until very recently, a 2-stage build of `main` with `flang` included worked with `clang-20` as build compiler since `flang` was only built in stage 2 and the freshly built `clang-21` does include the patch.. However, now

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-02 Thread Rainer Orth via cfe-commits
rorth wrote: /cherry-pick e71c8ea3cc73c8f7b0382468f355a254166d3a72 https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-05-02 Thread Rainer Orth via cfe-commits
https://github.com/rorth milestoned https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-04-26 Thread Rainer Orth via cfe-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-04-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. (I have limited internet access between April 20th and May 4th, and my response time may be delayed..) https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@li

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-04-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rainer Orth (rorth) Changes Since commit 613a077b05b8352a48695be295037306f5fca151, `flang` doesn't build any longer on Solaris/amd64: ``` flang/lib/Evaluate/intrinsics-library.cpp:225:26: error: address of overloaded function 'acos' does n

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-04-24 Thread Rainer Orth via cfe-commits
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/137141 Since commit 613a077b05b8352a48695be295037306f5fca151, `flang` doesn't build any longer on Solaris/amd64: ``` flang/lib/Evaluate/intrinsics-library.cpp:225:26: error: address of overloaded function 'acos' does not