[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-30 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > This is not being handled for AMDGPU Targets. > > I'm assuming this is an artifact of passing all arguments both the host > target and the offload target? @jhuber6 what's the correct way of filtering > out irrelevant codegen options? I don't know what the desired behavior i

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-30 Thread Matt Arsenault via cfe-commits
arsenm wrote: > This is not being handled for AMDGPU Targets. I'm assuming this is an artifact of passing all arguments both the host target and the offload target? @jhuber6 what's the correct way of filtering out irrelevant codegen options? https://github.com/llvm/llvm-project/pull/70262 __

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-29 Thread Pravin Jagtap via cfe-commits
pravinjagtap wrote: This is not being handled for AMDGPU Targets. @arsenm @yxsamliu @kzhuravl @ronlieb Is following case correct for AMDGPU Target ? I am not sure about the previous state before this change for AMGPU Target. ``` ... else if (Triple.getArch() == llvm::Triple::amdgcn) {

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/70262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 approved this pull request. https://github.com/llvm/llvm-project/pull/70262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-26 Thread Kito Cheng via cfe-commits
kito-cheng wrote: LGTM for the RISC-V bits, thanks :) https://github.com/llvm/llvm-project/pull/70262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-26 Thread Peter Smith via cfe-commits
https://github.com/smithp35 commented: I'm happy with this on the AArch64 side. If clang for a target defaults to position independent code this may lead to some -mcmodel=large projects failing to build, at least until they add -fno-pic Could we add this to the release notes? Perhaps in the f

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes -mcmodel= is supported for a few architectures. Reject the option for other architectures. * -mcmodel= is unsupported on x86-32. * -mcmodel=large is unsupported for PIC on AArch64. * -mcmodel= is unsupported

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-25 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/70262 -mcmodel= is supported for a few architectures. Reject the option for other architectures. * -mcmodel= is unsupported on x86-32. * -mcmodel=large is unsupported for PIC on AArch64. * -mcmodel= is unsupported for