[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/66283: Currently, clang emits LLVM IR that fails verifier for the following code: ``` template __global__ void foo(T x); void bar() { foo<<<1, 1>>>(0); } ``` This is due to clang putting the kernel handle for foo i

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Currently, clang emits LLVM IR that fails verifier for the following code: ``` template __global__ void foo(T x); void bar() { foo<<<1, 1>>>(0); } ``` This is due to clang putting the kernel handle for foo into comdat, which i

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-13 Thread Artem Belevich via cfe-commits
@@ -43,6 +44,9 @@ __global__ void kernelfunc() {} __global__ void kernel_decl(); +template +__global__ void temp_kernel_decl(T x); Artem-B wrote: Nit: rename temp -> template? `temp` is strongly associated with 'temporary'. https://github.com/llvm/llvm-proj

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

2023-09-14 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits