@@ -839,100 +842,84 @@ static void
updateResourceClassFlagsFromRecordType(RegisterBindingFlags &Flags,
const Type *FieldTy = FD->getType().getTypePtr();
if (const HLSLAttributedResourceType *AttrResType =
dyn_cast(FieldTy)) {
-updateResourceCl
https://github.com/hekota closed
https://github.com/llvm/llvm-project/pull/108924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/108924
>From 1dd552dfb6217804ba5e84a35e59e348622df581 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 16 Sep 2024 20:54:23 -0700
Subject: [PATCH 1/5] [HLSL][NFC] Remove RegisterBindingFlags struct
When diagnosin
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/108924
>From 1dd552dfb6217804ba5e84a35e59e348622df581 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 16 Sep 2024 20:54:23 -0700
Subject: [PATCH 1/5] [HLSL][NFC] Remove RegisterBindingFlags struct
When diagnosin
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/108924
>From 1dd552dfb6217804ba5e84a35e59e348622df581 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 16 Sep 2024 20:54:23 -0700
Subject: [PATCH 1/4] [HLSL][NFC] Remove RegisterBindingFlags struct
When diagnosin
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/108924
>From 1dd552dfb6217804ba5e84a35e59e348622df581 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 16 Sep 2024 20:54:23 -0700
Subject: [PATCH 1/4] [HLSL][NFC] Remove RegisterBindingFlags struct
When diagnosin
https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/108924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -828,101 +831,85 @@ static void
updateResourceClassFlagsFromRecordType(RegisterBindingFlags &Flags,
const Type *FieldTy = FD->getType().getTypePtr();
if (const HLSLAttributedResourceType *AttrResType =
dyn_cast(FieldTy)) {
-updateResourceCl
https://github.com/llvm-beanz approved this pull request.
One minor nit inline, but I think this is fine either way.
https://github.com/llvm/llvm-project/pull/108924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
@@ -828,101 +831,85 @@ static void
updateResourceClassFlagsFromRecordType(RegisterBindingFlags &Flags,
const Type *FieldTy = FD->getType().getTypePtr();
if (const HLSLAttributedResourceType *AttrResType =
dyn_cast(FieldTy)) {
-updateResourceCl
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/108924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Helena Kotas (hekota)
Changes
When diagnosing register bindings we just need to make sure there is a resource
that matches the provided register type. We can emit the diagnostics right away
instead of collecting flags in the RegisterBindin
@@ -41,6 +41,47 @@
using namespace clang;
+enum class RegisterType { SRV, UAV, CBuffer, Sampler, C, I, Invalid };
hekota wrote:
This is moved from below.
https://github.com/llvm/llvm-project/pull/108924
___
cfe-co
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Helena Kotas (hekota)
Changes
When diagnosing register bindings we just need to make sure there is a resource
that matches the provided register type. We can emit the diagnostics right away
instead of collecting flags in the RegisterBindi
https://github.com/hekota created
https://github.com/llvm/llvm-project/pull/108924
When diagnosing register bindings we just need to make sure there is a resource
that matches the provided register type. We can emit the diagnostics right away
instead of collecting flags in the RegisterBindingF
15 matches
Mail list logo
