https://github.com/hekota closed
https://github.com/llvm/llvm-project/pull/132828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/132828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/damyanp commented:
LGTM, but probably need someone with more area expertise than me to approve it.
https://github.com/llvm/llvm-project/pull/132828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/joaosaffran approved this pull request.
Code LGTM
https://github.com/llvm/llvm-project/pull/132828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Helena Kotas (hekota)
Changes
Fixes #132309
---
Full diff: https://github.com/llvm/llvm-project/pull/132828.diff
2 Files Affected:
- (modified) clang/lib/CodeGen/HLSLBufferLayoutBuilder.cpp (+13-13)
- (modified) clang/test/CodeGenHLSL/c
https://github.com/hekota created
https://github.com/llvm/llvm-project/pull/132828
Fixes #132309
>From ac823de8971dc7cfd2516860badd24fe983968eb Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 24 Mar 2025 14:05:47 -0700
Subject: [PATCH] [HLSL] Fix codegen to support classes in `cbuffer`