https://github.com/paschalis-mpeis closed
https://github.com/llvm/llvm-project/pull/78749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/david-arm approved this pull request.
LGTM as well!
https://github.com/llvm/llvm-project/pull/78749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mgabka approved this pull request.
It LGTM, but probably worth to give some extra time in case anybody else thinks
differently, it would be really good to have it on LLVM18 as well
https://github.com/llvm/llvm-project/pull/78749
https://github.com/paschalis-mpeis updated
https://github.com/llvm/llvm-project/pull/78749
>From f664beed712de47796759586a171d86d73fb9790 Mon Sep 17 00:00:00 2001
From: Paschalis Mpeis
Date: Fri, 19 Jan 2024 16:27:20 +
Subject: [PATCH 1/3] [LTO] Fix Veclib flags correctly pass to LTO flags
@@ -31,3 +31,21 @@
// RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target
arm64-apple-ios8.0.0 -### 2>&1 | FileCheck
--check-prefix=CHECK-LINK-NODEFAULTLIBS %s
// CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate"
+
+
+/* Verify that the correct vector library is
@@ -31,3 +31,27 @@
// RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target
arm64-apple-ios8.0.0 -### 2>&1 | FileCheck
--check-prefix=CHECK-LINK-NODEFAULTLIBS %s
// CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate"
+
+
+/* Verify that the correct vector library is
https://github.com/paschalis-mpeis updated
https://github.com/llvm/llvm-project/pull/78749
>From c342eea051da7eed2ef4541e5daf445114258e1d Mon Sep 17 00:00:00 2001
From: Paschalis Mpeis
Date: Fri, 19 Jan 2024 16:27:20 +
Subject: [PATCH 1/2] [LTO] Fix Veclib flags correctly pass to LTO flags
@@ -31,3 +31,27 @@
// RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target
arm64-apple-ios8.0.0 -### 2>&1 | FileCheck
--check-prefix=CHECK-LINK-NODEFAULTLIBS %s
// CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate"
+
+
+/* Verify that the correct vector library is
@@ -783,6 +783,28 @@ void tools::addLTOOptions(const ToolChain ,
const ArgList ,
"-generate-arange-section"));
}
+ // Pass vector library arguments to LTO.
+ Arg *ArgVecLib = Args.getLastArg(options::OPT_fveclib);
+ if (ArgVecLib
@@ -783,6 +783,28 @@ void tools::addLTOOptions(const ToolChain ,
const ArgList ,
"-generate-arange-section"));
}
+ // Pass vector library arguments to LTO.
+ Arg *ArgVecLib = Args.getLastArg(options::OPT_fveclib);
+ if (ArgVecLib
https://github.com/paschalis-mpeis updated
https://github.com/llvm/llvm-project/pull/78749
>From c342eea051da7eed2ef4541e5daf445114258e1d Mon Sep 17 00:00:00 2001
From: Paschalis Mpeis
Date: Fri, 19 Jan 2024 16:27:20 +
Subject: [PATCH] [LTO] Fix Veclib flags correctly pass to LTO flags
https://github.com/paschalis-mpeis edited
https://github.com/llvm/llvm-project/pull/78749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paschalis-mpeis edited
https://github.com/llvm/llvm-project/pull/78749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paschalis-mpeis edited
https://github.com/llvm/llvm-project/pull/78749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -31,3 +31,31 @@
// RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target
arm64-apple-ios8.0.0 -### 2>&1 | FileCheck
--check-prefix=CHECK-LINK-NODEFAULTLIBS %s
// CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate"
+
+
+/* Verify that the correct vector library is
@@ -783,6 +783,28 @@ void tools::addLTOOptions(const ToolChain ,
const ArgList ,
"-generate-arange-section"));
}
+ // Pass vector library arguments to LTO.
+ Arg *ArgVecLib = Args.getLastArg(options::OPT_fveclib);
+ if (ArgVecLib
@@ -783,6 +783,28 @@ void tools::addLTOOptions(const ToolChain ,
const ArgList ,
"-generate-arange-section"));
}
+ // Pass vector library arguments to LTO.
+ Arg *ArgVecLib = Args.getLastArg(options::OPT_fveclib);
+ if (ArgVecLib
@@ -31,3 +31,31 @@
// RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target
arm64-apple-ios8.0.0 -### 2>&1 | FileCheck
--check-prefix=CHECK-LINK-NODEFAULTLIBS %s
// CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate"
+
+
+/* Verify that the correct vector library is
@@ -31,3 +31,31 @@
// RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target
arm64-apple-ios8.0.0 -### 2>&1 | FileCheck
--check-prefix=CHECK-LINK-NODEFAULTLIBS %s
// CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate"
+
+
+/* Verify that the correct vector library is
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Paschalis Mpeis (paschalis-mpeis)
Changes
Flags `-fveclib=name` were not passed to LTO flags.
This pass fixes that by converting the `-fveclib` flags to their relevant names
for opt's `-vector-lib=name`
https://github.com/paschalis-mpeis created
https://github.com/llvm/llvm-project/pull/78749
Flags `-fveclib=name` were not passed to LTO flags.
This pass fixes that by converting the `-fveclib` flags to their relevant names
for opt's `-vector-lib=name` flags.
For example:
`-fveclib=SLEEF`
21 matches
Mail list logo
