https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/68215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JonChesterfield approved this pull request.
LinkerWrapper turning into a linker is kind of inevitable and not a very happy
thing.
One option would be to lean on lld for amdgpu and split out the nvptx stuff in
the hopes that we eventually have an alternative to nvlink, but
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/68215
>From f2e29b6136d245e0712bfb87de1f4253d12dd6f5 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Wed, 4 Oct 2023 07:34:01 -0500
Subject: [PATCH] [LinkerWrapper] Fix resolution of weak symbols during LTO
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ceec9a7874af2eea8b00b5616fad388ccfa2b4f3
0fec18f2f745b798fe48ce08c1441c3439d009a6 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Summary:
Weak symbols are supposed to have the semantics that they can be
overriden by a strong (i.e. global) definition. This wasn't being
respected by the LTO pass because we simply used the first definition
that was available. This patch
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/68215
Summary:
Weak symbols are supposed to have the semantics that they can be
overriden by a strong (i.e. global) definition. This wasn't being
respected by the LTO pass because we simply used the first definition
