ilya-biryukov wrote:
There's quite a few failures:
https://gist.github.com/ilya-biryukov/380d84dfe53f839f449231eb9a2dd46c
The logic that sets up module structure from module maps before starting to
load PCMs definitely needs to be reworked (and I'm not sure if it can be in the
first place). I
ilya-biryukov wrote:
> Have you tried changing the behavior of the existing `-fmodule-map-file=` to
> load the file after we load module files? If so, what kinds of things do you
> see breaking or changing? If we can avoid it, I think it would be better to
> only have a single mode here, and
ian-twilightcoder wrote:
+ @Bigcheese and @jansvoboda11 as I think they know this area of the code better
https://github.com/llvm/llvm-project/pull/88893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zygoloid wrote:
Have you tried changing the behavior of the existing `-fmodule-map-file=` to
load the file after we load module files? If so, what kinds of things do you
see breaking or changing? If we can avoid it, I think it would be better to
only have a single mode here, and loading the
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/88893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Ilya Biryukov (ilya-biryukov)
Changes
If the same module map is passed to multiple compilation actions that build
PCMs and later load them, we currently create a new FileID for it every time a
PCM gets built.
This is not very
https://github.com/ilya-biryukov created
https://github.com/llvm/llvm-project/pull/88893
If the same module map is passed to multiple compilation actions that build
PCMs and later load them, we currently create a new FileID for it every time a
PCM gets built.
This is not very problematic in
