https://github.com/Keenuts edited
https://github.com/llvm/llvm-project/pull/70193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Keenuts closed
https://github.com/llvm/llvm-project/pull/70193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -65,7 +65,7 @@ class CXXFieldCollector {
/// getCurFields - Pointer to array of fields added to the currently parsed
/// class.
- FieldDecl **getCurFields() { return &*(Fields.end() - getCurNumFields()); }
Keenuts wrote:
Thanks for the review and
@@ -65,7 +65,7 @@ class CXXFieldCollector {
/// getCurFields - Pointer to array of fields added to the currently parsed
/// class.
- FieldDecl **getCurFields() { return &*(Fields.end() - getCurNumFields()); }
shafik wrote:
I think this is basically
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nathan Gauër (Keenuts)
Changes
This was found by doing bound-checking on SmallVector iterator usage. When the
count is 0, the end iterator is dereferenced to get its address. This doesn't
seem to be an issue in practice as most of the
https://github.com/Keenuts edited
https://github.com/llvm/llvm-project/pull/70193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Keenuts ready_for_review
https://github.com/llvm/llvm-project/pull/70193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Keenuts wrote:
CI seems OK, except clang format which complains about an unrelated line.
Marking as ready.
https://github.com/llvm/llvm-project/pull/70193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Keenuts created
https://github.com/llvm/llvm-project/pull/70193
This was found by doing bound-checking on SmallVector iterator usage. When the
count is 0, the end iterator is dereferenced to get its address. This doesn't
seem to be an issue in practice as most of the time,
